Skip to content

RC Model fixes (and some DA fixes) #72

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
kysolvik wants to merge 4 commits into
base: main
Choose a base branch
from
Open

RC Model fixes (and some DA fixes) #72

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
dfe4148
ETKF and Var3D DS assignment use actual var name instead of defaultin…
kysolvik May 2, 2025
f87feb0
Updating rc to return full n_step forecast and new index dimension name
kysolvik May 2, 2025
ab53fbd
Fix xarray accessor split method repeating same data
kysolvik May 2, 2025
37c50e2
RC model: Remove extra methods, add type hints, rename generate() to …
kysolvik May 2, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion dabench/dacycler/_etkf.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -210,4 +210,4 @@ def _cycle_obsop(self,
R=R,
rho=self.multiplicative_inflation)

return Xb_ds.assign(x=(['ensemble','i'], Xa.T))
return Xb_ds.assign({list(Xb_ds.data_vars)[0]:(Xb_ds.dims, Xa.T)})
2 changes: 1 addition & 1 deletion dabench/dacycler/_var3d.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -103,4 +103,4 @@ def _cycle_obsop(self,
xa, ierr = jscipy.sparse.linalg.cg(A, b1, x0=xb, tol=1e-05,
maxiter=1000)

return xb_ds.assign(x=(xb_ds.dims, xa.T))
return xb_ds.assign({list(xb_ds.data_vars)[0]:(xb_ds.dims, xa.T)})
1 change: 1 addition & 0 deletions dabench/data/_xarray_accessor.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -48,6 +48,7 @@ def split_train_val_test(self,
for sl in split_lengths:
end_i = start_i + sl
out_ds.append(self._obj.isel(time=slice(start_i, end_i)))
start_i = end_i
return tuple(out_ds)


Expand Down
Loading