fix: stop false "update available" for same-version images, plus review fixes and Skip - #99
Merged
Merged
Conversation
…ew fixes The checker compared the registry digest against only the FIRST of the image's RepoDigests. Docker keeps several digests for one repo when the same image is known under more than one manifest (tag re-pushed with a new index, or pulled via two tags), listed lexically rather than newest-first — so an up-to-date container could be flagged forever, showing the same version on both sides, and updating it changed nothing. All matching repo digests are now tracked and compared. Also: - sse: a finished session's cleanup timer could delete a NEW session started within 30s (e.g. Revert right after a failed update), hanging its log. - notify: ntfy titles contain emoji and were sent as a header, which fetch rejects — every real ntfy notification threw (the ASCII test passed). Title/tags now go in query params. Messages show "current → available". - standalone recreate/revert: no longer pins the old image's ENV/CMD/labels onto the new image; keeps anonymous volumes and a custom hostname; renames the old container aside and restores it if create/start fails. - checker: check each ref once but evaluate every container running it; skip containers with no registry digest; single-flight concurrent checks; breaking-change scan uses the remembered running version. - scheduler: notifications use remembered versions; dashboards refresh after the daily scan. - client: brief SSE disconnects no longer mark an update failed; "Update all" runs one container at a time per stack; same-version rebuilds are labelled. feat: "Skip" an offered update until a newer build is published Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01KiL5R3bRpvGk6QP3E21eHF
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
POST /api/skip,DELETE /api/skip/:ref).Testing
🤖 Generated with Claude Code
https://claude.ai/code/session_01KiL5R3bRpvGk6QP3E21eHF
Generated by Claude Code