Skip to content

fix: Generated validators counting unfinished pattern matches as non-matches - #1766

Merged
Stranger6667 merged 1 commit into
masterfrom
dd/regex-indeterminate-steps
Oct 16, 2026
Merged

Stranger6667 merged 1 commit into
masterfrom
dd/regex-indeterminate-steps

Conversation

@Stranger6667

Copy link
Copy Markdown
Owner

No description provided.

@codecov

codecov Bot commented Oct 16, 2026 •

Copy link
Copy Markdown

Codecov Report

❌ Patch coverage is 98.15951% with 3 lines in your changes missing coverage. Please review.
✅ Project coverage is 96.81%. Comparing base (4fd30be) to head (0a47eac).

Files with missing lines Patch % Lines
crates/jsonschema/src/lib.rs 96.29% 3 Missing ⚠️
Additional details and impacted files
@@           Coverage Diff            @@
##           master    #1766    +/-   ##
========================================
  Coverage   96.81%   96.81%            
========================================
  Files         210      210            
  Lines       66879    67032   +153     
========================================
+ Hits        64746    64896   +150     
- Misses       2133     2136     +3     

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@codspeed

codspeed Bot commented Oct 16, 2026 •

Copy link
Copy Markdown

Merging this PR will not alter performance

⚠️ 36 benchmarks spent significant time in system calls

System calls cannot be consistently instrumented, so they are not included in the measure, which understates the real cost. Please switch to the Walltime instrument to accurately measure system calls.

Measurement and system calls

✅ 278 untouched benchmarks


Comparing dd/regex-indeterminate-steps (0a47eac) with master (4fd30be)

Open in CodSpeed

…n-matches

Signed-off-by: Dmitry Dygalo <dmitry@dygalo.dev>
@Stranger6667
Stranger6667 force-pushed the dd/regex-indeterminate-steps branch from 81c1d21 to 0a47eac Compare October 16, 2026 18:34
@Stranger6667
Stranger6667 merged commit 9578d4e into master Oct 16, 2026
102 of 103 checks passed
@Stranger6667
Stranger6667 deleted the dd/regex-indeterminate-steps branch October 16, 2026 19:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant