Skip to content

fix: canonicalize treating regex matches the engine cannot finish as non-matches - #1768

Merged
Stranger6667 merged 1 commit into
masterfrom
dd/canonical-unfinished-regex
Oct 16, 2026
Merged

Stranger6667 merged 1 commit into
masterfrom
dd/canonical-unfinished-regex

Conversation

@Stranger6667

Copy link
Copy Markdown
Owner

No description provided.

@codecov

codecov Bot commented Oct 16, 2026 •

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 96.81%. Comparing base (9578d4e) to head (6cc79ac).
⚠️ Report is 1 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #1768      +/-   ##
==========================================
- Coverage   97.70%   96.81%   -0.90%     
==========================================
  Files         200      210      +10     
  Lines       62607    67046    +4439     
==========================================
+ Hits        61172    64910    +3738     
- Misses       1435     2136     +701     

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@codspeed

codspeed Bot commented Oct 16, 2026

Copy link
Copy Markdown

Merging this PR will not alter performance

⚠️ 36 benchmarks spent significant time in system calls

System calls cannot be consistently instrumented, so they are not included in the measure, which understates the real cost. Please switch to the Walltime instrument to accurately measure system calls.

Measurement and system calls

✅ 278 untouched benchmarks


Comparing dd/canonical-unfinished-regex (6cc79ac) with master (9578d4e)

Open in CodSpeed

@github-actions

Copy link
Copy Markdown

canonical-ecosystem results

✅ No canonical output changes across 226,955 schemas from 3,524 documents.

Old New
err 792 792
ok 226,045 226,045
prepare-error 253 253
raw 118 118

@Stranger6667
Stranger6667 merged commit 016982a into master Oct 16, 2026
96 of 104 checks passed
@Stranger6667
Stranger6667 deleted the dd/canonical-unfinished-regex branch October 16, 2026 20:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant