Skip to content

Fix deprecated null passed to str_replace in get_field_value_for_new_entry #3332

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wzul wants to merge 1 commit into from
Closed

Fix deprecated null passed to str_replace in get_field_value_for_new_entry #3332

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 5 additions & 1 deletion classes/helpers/FrmEntriesHelper.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -128,8 +128,12 @@ private static function get_field_value_for_new_entry( $field, $reset, $args ) {
self::get_posted_value( $field, $new_value, $args );
}

// A field with no default value has a null default_value, and a field type
// whose value is not posted back leaves it null too. str_replace() warns on
// a null subject in PHP 8.1+, so cast first: this keeps returning the empty
// string the caller already relied on.
if ( ! is_array( $new_value ) ) {
return str_replace( '"', '"', $new_value );
return str_replace( '"', '"', (string) $new_value );
}

return $new_value;
Expand Down