Skip to content

Fix Style builder labels focusing hidden color-picker/slider inputs #3449

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
vivi-the-going-merry wants to merge 16 commits into
base: master
Choose a base branch
from
Open

Fix Style builder labels focusing hidden color-picker/slider inputs #3449

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
16 commits
Select commit Hold shift + click to select a range
f998b68
Fix Style builder labels pointing at hidden color-picker/slider inputs
vivi-the-going-merry[bot] Sep 22, 2026
2ca0e57
Add regression coverage for style-builder label focus targets
vivi-the-going-merry[bot] Sep 22, 2026
a771f0d
Fix styleLabelFocusTargets.cy.js: select label's post-init id, not it…
vivi-the-going-merry[bot] Sep 22, 2026
c52110b
Fix styleLabelFocusTargets.cy.js: assert hidden state before click, n…
vivi-the-going-merry[bot] Sep 23, 2026
9591399
Skip a for="" that targets a disabled input for Width/Height on the p…
vivi-the-going-merry[bot] Sep 23, 2026
63d47ac
Extend disabled-input label fix to the remaining single-value sliders
vivi-the-going-merry[bot] Sep 23, 2026
48c4795
Merge pull request #3468 from Strategy11/fix/issue-3454-slider-label-…
Crabcyborg Sep 30, 2026
9741f20
Merge master into fix/issue-3439-style-label-focus-targets
vivi-the-going-merry[bot] Sep 30, 2026
510d6a4
Give the Styles page first element lookups a 10s timeout in the label…
vivi-the-going-merry[bot] Sep 30, 2026
80ff761
Merge branch 'master' into fix/issue-3439-style-label-focus-targets
Crabcyborg Oct 1, 2026
cce54fc
New maybe echo for
Crabcyborg Oct 1, 2026
8510e0b
Simplify further
Crabcyborg Oct 1, 2026
f8fe922
Move the whole label into a function
Crabcyborg Oct 1, 2026
c44309a
Update additional labels
Crabcyborg Oct 1, 2026
a9a9966
Address review nits: drop unused maybe_echo_for, unused label id, sho…
vivi-the-going-merry[bot] Oct 1, 2026
dcb95ff
Add PHPUnit coverage for slider label for/data-slider-label-for rule
vivi-the-going-merry[bot] Oct 1, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
21 changes: 7 additions & 14 deletions classes/views/styles/_buttons.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -52,8 +52,7 @@ class="frm-style-item-heading"><?php esc_html_e( 'Font Color', 'formidable' ); ?
</div>

<div class="frm5 frm_form_field">
<label
class="frm-style-item-heading"><?php esc_html_e( 'Font Size', 'formidable' ); ?></label>
<?php FrmSliderStyleComponent::style_item_heading( $style, 'submit_font_size', 'frm_submit_font_size-value', __( 'Font Size', 'formidable' ) ); ?>

@deepsource-io deepsource-io Bot Oct 1, 2026

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Variable $style might not be defined


A variable has been used but not defined, which may result in warnings during program execution. This can also cause bugs since the intended usage scope of the variable is not known.

@deepsource-io deepsource-io Bot Oct 1, 2026

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Variable $style might not be defined


A variable has been used but not defined, which may result in warnings during program execution. This can also cause bugs since the intended usage scope of the variable is not known.

</div>
<div class="frm7 frm_form_field">
<?php
Expand Down Expand Up @@ -87,8 +86,7 @@ class="frm-style-item-heading"><?php esc_html_e( 'Weight', 'formidable' ); ?></l
</div>

<div class="frm5 frm_form_field">
<label
class="frm-style-item-heading"><?php esc_html_e( 'Width', 'formidable' ); ?></label>
<?php FrmSliderStyleComponent::style_item_heading( $style, 'submit_width', 'frm_submit_width-value', __( 'Width', 'formidable' ) ); ?>

@deepsource-io deepsource-io Bot Oct 1, 2026

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Variable $style might not be defined


A variable has been used but not defined, which may result in warnings during program execution. This can also cause bugs since the intended usage scope of the variable is not known.

@deepsource-io deepsource-io Bot Oct 1, 2026

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Variable $style might not be defined


A variable has been used but not defined, which may result in warnings during program execution. This can also cause bugs since the intended usage scope of the variable is not known.

</div>
<div class="frm7 frm_form_field">
<?php
Expand All @@ -105,8 +103,7 @@ class="frm-style-item-heading"><?php esc_html_e( 'Width', 'formidable' ); ?></la
</div>

<div class="frm5 frm_form_field">
<label
class="frm-style-item-heading"><?php esc_html_e( 'Height', 'formidable' ); ?></label>
<?php FrmSliderStyleComponent::style_item_heading( $style, 'submit_height', 'frm_submit_height-value', __( 'Height', 'formidable' ) ); ?>

@deepsource-io deepsource-io Bot Oct 1, 2026

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Variable $style might not be defined


A variable has been used but not defined, which may result in warnings during program execution. This can also cause bugs since the intended usage scope of the variable is not known.

@deepsource-io deepsource-io Bot Oct 1, 2026

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Variable $style might not be defined


A variable has been used but not defined, which may result in warnings during program execution. This can also cause bugs since the intended usage scope of the variable is not known.

</div>
<div class="frm7 frm_form_field">
<?php
Expand Down Expand Up @@ -141,8 +138,7 @@ class="frm-style-item-heading"><?php esc_html_e( 'Border Color', 'formidable' );
</div>

<div class="frm5 frm_form_field">
<label
class="frm-style-item-heading"><?php esc_html_e( 'Border Width', 'formidable' ); ?></label>
<?php FrmSliderStyleComponent::style_item_heading( $style, 'submit_border_width', 'frm_submit_border_width-value', __( 'Border Width', 'formidable' ) ); ?>

@deepsource-io deepsource-io Bot Oct 1, 2026

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Variable $style might not be defined


A variable has been used but not defined, which may result in warnings during program execution. This can also cause bugs since the intended usage scope of the variable is not known.

@deepsource-io deepsource-io Bot Oct 1, 2026

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Variable $style might not be defined


A variable has been used but not defined, which may result in warnings during program execution. This can also cause bugs since the intended usage scope of the variable is not known.

</div>
<div class="frm7 frm_form_field">
<?php
Expand Down Expand Up @@ -176,8 +172,7 @@ class="frm-style-item-heading"><?php esc_html_e( 'Shadow', 'formidable' ); ?></l
</div>

<div class="frm5 frm_form_field">
<label
class="frm-style-item-heading"><?php esc_html_e( 'Corner Radius', 'formidable' ); ?></label>
<?php FrmSliderStyleComponent::style_item_heading( $style, 'submit_border_radius', 'frm_submit_border_radius-value', __( 'Corner Radius', 'formidable' ) ); ?>

@deepsource-io deepsource-io Bot Oct 1, 2026

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Variable $style might not be defined


A variable has been used but not defined, which may result in warnings during program execution. This can also cause bugs since the intended usage scope of the variable is not known.

@deepsource-io deepsource-io Bot Oct 1, 2026

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Variable $style might not be defined


A variable has been used but not defined, which may result in warnings during program execution. This can also cause bugs since the intended usage scope of the variable is not known.

</div>
<div class="frm7 frm_form_field">
<?php
Expand All @@ -194,6 +189,7 @@ class="frm-style-item-heading"><?php esc_html_e( 'Corner Radius', 'formidable' )

<div class="frm5 frm_form_field">
<label
<?php FrmSliderStyleComponent::echo_label_attributes( $style, 'submit_margin', 'frm_submit_margin-value' ); ?>

@deepsource-io deepsource-io Bot Oct 1, 2026

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Variable $style might not be defined


A variable has been used but not defined, which may result in warnings during program execution. This can also cause bugs since the intended usage scope of the variable is not known.

@deepsource-io deepsource-io Bot Oct 1, 2026

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Variable $style might not be defined


A variable has been used but not defined, which may result in warnings during program execution. This can also cause bugs since the intended usage scope of the variable is not known.

class="frm-style-item-heading">
<?php esc_html_e( 'Margin', 'formidable' ); ?>
<span class="frm_help frmfont frm_tooltip_icon" data-placement="right" data-container="body" data-original-title="<?php esc_attr_e( 'Used for navigation buttons too', 'formidable' ); ?>"></span>
Expand All @@ -214,10 +210,7 @@ class="frm-style-item-heading">
</div>

<div class="frm5 frm_form_field">
<label
class="frm-style-item-heading">
<?php esc_html_e( 'Padding', 'formidable' ); ?>
</label>
<?php FrmSliderStyleComponent::style_item_heading( $style, 'submit_padding', 'frm_submit_padding-value', __( 'Padding', 'formidable' ) ); ?>

@deepsource-io deepsource-io Bot Oct 1, 2026

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Variable $style might not be defined


A variable has been used but not defined, which may result in warnings during program execution. This can also cause bugs since the intended usage scope of the variable is not known.

@deepsource-io deepsource-io Bot Oct 1, 2026

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Variable $style might not be defined


A variable has been used but not defined, which may result in warnings during program execution. This can also cause bugs since the intended usage scope of the variable is not known.

</div>
<div class="frm7 frm_form_field">
<?php
Expand Down
3 changes: 1 addition & 2 deletions classes/views/styles/_check-box-radio-fields.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -22,8 +22,7 @@ class="frm-style-item-heading"><?php esc_html_e( 'Color', 'formidable' ); ?></la
</div>

<div class="frm5 frm_form_field">
<label
class="frm-style-item-heading"><?php esc_html_e( 'Font Size', 'formidable' ); ?></label>
<?php FrmSliderStyleComponent::style_item_heading( $style, 'check_font_size', 'frm_check_font_size-value', __( 'Font Size', 'formidable' ) ); ?>

@deepsource-io deepsource-io Bot Oct 1, 2026

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Variable $style might not be defined


A variable has been used but not defined, which may result in warnings during program execution. This can also cause bugs since the intended usage scope of the variable is not known.

@deepsource-io deepsource-io Bot Oct 1, 2026

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Variable $style might not be defined


A variable has been used but not defined, which may result in warnings during program execution. This can also cause bugs since the intended usage scope of the variable is not known.

</div>
<div class="frm7 frm_form_field">
<?php
Expand Down
8 changes: 3 additions & 5 deletions classes/views/styles/_field-colors.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -74,8 +74,7 @@ class="frm-style-item-heading"><?php esc_html_e( 'Border', 'formidable' ); ?></l
</div>

<div class="frm5 frm_form_field">
<label
class="frm-style-item-heading"><?php esc_html_e( 'Border Width', 'formidable' ); ?></label>
<?php FrmSliderStyleComponent::style_item_heading( $style, 'field_border_width', 'frm_field_border_width-value', __( 'Border Width', 'formidable' ) ); ?>

@deepsource-io deepsource-io Bot Oct 1, 2026

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Variable $style might not be defined


A variable has been used but not defined, which may result in warnings during program execution. This can also cause bugs since the intended usage scope of the variable is not known.

@deepsource-io deepsource-io Bot Oct 1, 2026

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Variable $style might not be defined


A variable has been used but not defined, which may result in warnings during program execution. This can also cause bugs since the intended usage scope of the variable is not known.

</div>
<div class="frm7 frm_form_field">
<?php
Expand Down Expand Up @@ -174,7 +173,7 @@ class="frm-style-item-heading"><?php esc_html_e( 'Border', 'formidable' ); ?></l
</div>

<div class="frm5 frm_form_field">
<label class="frm-style-item-heading"><?php esc_html_e( 'Remove Box Shadow', 'formidable' ); ?></label>
<label for="remove_box_shadow_active" class="frm-style-item-heading"><?php esc_html_e( 'Remove Box Shadow', 'formidable' ); ?></label>
</div>
<div class="frm7 frm_form_field frm-style-component">
<?php
Expand Down Expand Up @@ -308,8 +307,7 @@ class="frm-style-item-heading"><?php esc_html_e( 'Border', 'formidable' ); ?></l
</div>

<div class="frm5 frm_form_field">
<label
class="frm-style-item-heading"><?php esc_html_e( 'Border Width', 'formidable' ); ?></label>
<?php FrmSliderStyleComponent::style_item_heading( $style, 'border_width_error', 'frm_border_width_error-value', __( 'Border Width', 'formidable' ) ); ?>

@deepsource-io deepsource-io Bot Oct 1, 2026

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Variable $style might not be defined


A variable has been used but not defined, which may result in warnings during program execution. This can also cause bugs since the intended usage scope of the variable is not known.

@deepsource-io deepsource-io Bot Oct 1, 2026

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Variable $style might not be defined


A variable has been used but not defined, which may result in warnings during program execution. This can also cause bugs since the intended usage scope of the variable is not known.

</div>
<div class="frm7 frm_form_field">
<?php
Expand Down
6 changes: 2 additions & 4 deletions classes/views/styles/_field-description.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -22,8 +22,7 @@ class="frm-style-item-heading"><?php esc_html_e( 'Color', 'formidable' ); ?></la
</div>

<div class="frm5 frm_form_field">
<label
class="frm-style-item-heading"><?php esc_html_e( 'Font Size', 'formidable' ); ?></label>
<?php FrmSliderStyleComponent::style_item_heading( $style, 'description_font_size', 'frm_description_font_size-value', __( 'Font Size', 'formidable' ) ); ?>

@deepsource-io deepsource-io Bot Oct 1, 2026

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Variable $style might not be defined


A variable has been used but not defined, which may result in warnings during program execution. This can also cause bugs since the intended usage scope of the variable is not known.

@deepsource-io deepsource-io Bot Oct 1, 2026

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Variable $style might not be defined


A variable has been used but not defined, which may result in warnings during program execution. This can also cause bugs since the intended usage scope of the variable is not known.

</div>
<div class="frm7 frm_form_field">
<?php
Expand Down Expand Up @@ -94,8 +93,7 @@ class="frm-style-item-heading"><?php esc_html_e( 'Align', 'formidable' ); ?></la
</div>

<div class="frm5 frm_form_field">
<label
class="frm-style-item-heading"><?php esc_html_e( 'Margin', 'formidable' ); ?></label>
<?php FrmSliderStyleComponent::style_item_heading( $style, 'description_margin', 'frm_description_margin-value', __( 'Margin', 'formidable' ) ); ?>

@deepsource-io deepsource-io Bot Oct 1, 2026

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Variable $style might not be defined


A variable has been used but not defined, which may result in warnings during program execution. This can also cause bugs since the intended usage scope of the variable is not known.

@deepsource-io deepsource-io Bot Oct 1, 2026

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Variable $style might not be defined


A variable has been used but not defined, which may result in warnings during program execution. This can also cause bugs since the intended usage scope of the variable is not known.

</div>
<div class="frm7 frm_form_field frm-md-z-index">
<?php
Expand Down
9 changes: 3 additions & 6 deletions classes/views/styles/_field-labels.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -36,8 +36,7 @@ class="frm-style-item-heading"><?php esc_html_e( 'Color', 'formidable' ); ?></la
</div>

<div class="frm5 frm_form_field">
<label
class="frm-style-item-heading"><?php esc_html_e( 'Font Size', 'formidable' ); ?></label>
<?php FrmSliderStyleComponent::style_item_heading( $style, 'font_size', 'frm_font_size-value', __( 'Font Size', 'formidable' ) ); ?>

@deepsource-io deepsource-io Bot Oct 1, 2026

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Variable $style might not be defined


A variable has been used but not defined, which may result in warnings during program execution. This can also cause bugs since the intended usage scope of the variable is not known.

@deepsource-io deepsource-io Bot Oct 1, 2026

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Variable $style might not be defined


A variable has been used but not defined, which may result in warnings during program execution. This can also cause bugs since the intended usage scope of the variable is not known.

</div>
<div class="frm7 frm_form_field">
<?php
Expand Down Expand Up @@ -105,8 +104,7 @@ class="frm-style-item-heading"><?php esc_html_e( 'Align', 'formidable' ); ?></la
</div>

<div class="frm5 frm_form_field">
<label
class="frm-style-item-heading"><?php esc_html_e( 'Width', 'formidable' ); ?></label>
<?php FrmSliderStyleComponent::style_item_heading( $style, 'width', 'frm_width-value', __( 'Width', 'formidable' ) ); ?>

@deepsource-io deepsource-io Bot Oct 1, 2026

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Variable $style might not be defined


A variable has been used but not defined, which may result in warnings during program execution. This can also cause bugs since the intended usage scope of the variable is not known.

@deepsource-io deepsource-io Bot Oct 1, 2026

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Variable $style might not be defined


A variable has been used but not defined, which may result in warnings during program execution. This can also cause bugs since the intended usage scope of the variable is not known.

</div>
<div class="frm7 frm_form_field frm-md-z-index">
<?php
Expand All @@ -122,8 +120,7 @@ class="frm-style-item-heading"><?php esc_html_e( 'Width', 'formidable' ); ?></la
</div>

<div class="frm5 frm_form_field">
<label
class="frm-style-item-heading"><?php esc_html_e( 'Padding', 'formidable' ); ?></label>
<?php FrmSliderStyleComponent::style_item_heading( $style, 'label_padding', 'frm_label_padding-value', __( 'Padding', 'formidable' ) ); ?>

@deepsource-io deepsource-io Bot Oct 1, 2026

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Variable $style might not be defined


A variable has been used but not defined, which may result in warnings during program execution. This can also cause bugs since the intended usage scope of the variable is not known.

@deepsource-io deepsource-io Bot Oct 1, 2026

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Variable $style might not be defined


A variable has been used but not defined, which may result in warnings during program execution. This can also cause bugs since the intended usage scope of the variable is not known.

</div>
<div class="frm7 frm_form_field">
<?php
Expand Down
21 changes: 6 additions & 15 deletions classes/views/styles/_field-sizes.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,9 +4,7 @@
}
?>
<div class="frm5 frm_form_field">
<label
for="frm_field_font_size"
class="frm-style-item-heading"><?php esc_html_e( 'Font Size', 'formidable' ); ?></label>
<?php FrmSliderStyleComponent::style_item_heading( $style, 'field_font_size', 'frm_field_font_size-value', __( 'Font Size', 'formidable' ) ); ?>

@deepsource-io deepsource-io Bot Oct 1, 2026

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Variable $style might not be defined


A variable has been used but not defined, which may result in warnings during program execution. This can also cause bugs since the intended usage scope of the variable is not known.

@deepsource-io deepsource-io Bot Oct 1, 2026

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Variable $style might not be defined


A variable has been used but not defined, which may result in warnings during program execution. This can also cause bugs since the intended usage scope of the variable is not known.

</div>
<div class="frm7 frm_form_field">
<?php
Expand Down Expand Up @@ -40,9 +38,7 @@ class="frm-style-item-heading"><?php esc_html_e( 'Weight', 'formidable' ); ?></l
</div>

<div class="frm5 frm_form_field">
<label
for="frm_field_height"
class="frm-style-item-heading"><?php esc_html_e( 'Height', 'formidable' ); ?></label>
<?php FrmSliderStyleComponent::style_item_heading( $style, 'field_height', 'frm_field_height-value', __( 'Height', 'formidable' ) ); ?>

@deepsource-io deepsource-io Bot Oct 1, 2026

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Variable $style might not be defined


A variable has been used but not defined, which may result in warnings during program execution. This can also cause bugs since the intended usage scope of the variable is not known.

@deepsource-io deepsource-io Bot Oct 1, 2026

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Variable $style might not be defined


A variable has been used but not defined, which may result in warnings during program execution. This can also cause bugs since the intended usage scope of the variable is not known.

</div>
<div class="frm7 frm_form_field">
<?php
Expand All @@ -57,9 +53,7 @@ class="frm-style-item-heading"><?php esc_html_e( 'Height', 'formidable' ); ?></l
?>
</div>
<div class="frm5 frm_form_field">
<label
for="frm_field_width"
class="frm-style-item-heading"><?php esc_html_e( 'Width', 'formidable' ); ?></label>
<?php FrmSliderStyleComponent::style_item_heading( $style, 'field_width', 'frm_field_width-value', __( 'Width', 'formidable' ) ); ?>

@deepsource-io deepsource-io Bot Oct 1, 2026

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Variable $style might not be defined


A variable has been used but not defined, which may result in warnings during program execution. This can also cause bugs since the intended usage scope of the variable is not known.

@deepsource-io deepsource-io Bot Oct 1, 2026

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Variable $style might not be defined


A variable has been used but not defined, which may result in warnings during program execution. This can also cause bugs since the intended usage scope of the variable is not known.

</div>
<div class="frm7 frm_form_field">
<?php
Expand All @@ -74,8 +68,7 @@ class="frm-style-item-heading"><?php esc_html_e( 'Width', 'formidable' ); ?></la
?>
</div>
<div class="frm5 frm_form_field">
<label
class="frm-style-item-heading"><?php esc_html_e( 'Padding', 'formidable' ); ?></label>
<?php FrmSliderStyleComponent::style_item_heading( $style, 'field_pad', 'frm_field_pad-value', __( 'Padding', 'formidable' ) ); ?>

@deepsource-io deepsource-io Bot Oct 1, 2026

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Variable $style might not be defined


A variable has been used but not defined, which may result in warnings during program execution. This can also cause bugs since the intended usage scope of the variable is not known.

@deepsource-io deepsource-io Bot Oct 1, 2026

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Variable $style might not be defined


A variable has been used but not defined, which may result in warnings during program execution. This can also cause bugs since the intended usage scope of the variable is not known.

</div>
<div class="frm7 frm_form_field">
<?php
Expand All @@ -91,8 +84,7 @@ class="frm-style-item-heading"><?php esc_html_e( 'Padding', 'formidable' ); ?></
?>
</div>
<div class="frm5 frm_form_field">
<label
class="frm-style-item-heading"><?php esc_html_e( 'Margin', 'formidable' ); ?></label>
<?php FrmSliderStyleComponent::style_item_heading( $style, 'field_margin', 'frm_field_margin-value', __( 'Margin', 'formidable' ) ); ?>

@deepsource-io deepsource-io Bot Oct 1, 2026

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Variable $style might not be defined


A variable has been used but not defined, which may result in warnings during program execution. This can also cause bugs since the intended usage scope of the variable is not known.

@deepsource-io deepsource-io Bot Oct 1, 2026

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Variable $style might not be defined


A variable has been used but not defined, which may result in warnings during program execution. This can also cause bugs since the intended usage scope of the variable is not known.

</div>
<div class="frm7 frm_form_field">
<?php
Expand All @@ -108,8 +100,7 @@ class="frm-style-item-heading"><?php esc_html_e( 'Margin', 'formidable' ); ?></l
?>
</div>
<div class="frm5 frm_form_field">
<label
class="frm-style-item-heading"><?php esc_html_e( 'Corner Radius', 'formidable' ); ?></label>
<?php FrmSliderStyleComponent::style_item_heading( $style, 'border_radius', 'frm_border_radius-value', __( 'Corner Radius', 'formidable' ) ); ?>

@deepsource-io deepsource-io Bot Oct 1, 2026

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Variable $style might not be defined


A variable has been used but not defined, which may result in warnings during program execution. This can also cause bugs since the intended usage scope of the variable is not known.

@deepsource-io deepsource-io Bot Oct 1, 2026

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Variable $style might not be defined


A variable has been used but not defined, which may result in warnings during program execution. This can also cause bugs since the intended usage scope of the variable is not known.

</div>
<div class="frm7 frm_form_field">
<?php
Expand Down
10 changes: 4 additions & 6 deletions classes/views/styles/_form-description.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,9 +5,7 @@
?>

<div class="frm5 frm_form_field">
<label
class="frm-style-item-heading"><?php esc_html_e( 'Font Size', 'formidable' ); ?>
</label>
<?php FrmSliderStyleComponent::style_item_heading( $style, 'form_desc_size', 'frm_form_desc_size-value', __( 'Font Size', 'formidable' ) ); ?>

@deepsource-io deepsource-io Bot Oct 1, 2026

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Variable $style might not be defined


A variable has been used but not defined, which may result in warnings during program execution. This can also cause bugs since the intended usage scope of the variable is not known.

@deepsource-io deepsource-io Bot Oct 1, 2026

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Variable $style might not be defined


A variable has been used but not defined, which may result in warnings during program execution. This can also cause bugs since the intended usage scope of the variable is not known.

</div>
<div class="frm7 frm_form_field">
<?php
Expand All @@ -22,7 +20,7 @@ class="frm-style-item-heading"><?php esc_html_e( 'Font Size', 'formidable' ); ?>
?>
</div>

<div class="frm5 frm_form_field"><label class="frm-style-item-heading"><?php esc_html_e( 'Color', 'formidable' ); ?></label></div>
<div class="frm5 frm_form_field"><label for="frm_form_desc_color" class="frm-style-item-heading"><?php esc_html_e( 'Color', 'formidable' ); ?></label></div>
<div class="frm7 frm_form_field">
<?php
new FrmColorpickerStyleComponent(
Expand All @@ -36,7 +34,7 @@ class="frm-style-item-heading"><?php esc_html_e( 'Font Size', 'formidable' ); ?>
?>
</div>

<div class="frm5 frm_form_field"><label class="frm-style-item-heading"><?php esc_html_e( 'Margin', 'formidable' ); ?></label></div>
<div class="frm5 frm_form_field"><?php FrmSliderStyleComponent::style_item_heading( $style, 'form_desc_margin_top', 'frm_form_desc_margin_top-value', __( 'Margin', 'formidable' ) ); ?></div>

@deepsource-io deepsource-io Bot Oct 1, 2026

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Variable $style might not be defined


A variable has been used but not defined, which may result in warnings during program execution. This can also cause bugs since the intended usage scope of the variable is not known.

@deepsource-io deepsource-io Bot Oct 1, 2026

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Variable $style might not be defined


A variable has been used but not defined, which may result in warnings during program execution. This can also cause bugs since the intended usage scope of the variable is not known.

<div class="frm7 frm_form_field">
<?php
new FrmSliderStyleComponent(
Expand Down Expand Up @@ -65,7 +63,7 @@ class="frm-style-item-heading"><?php esc_html_e( 'Font Size', 'formidable' ); ?>
?>
</div>

<div class="frm5 frm_form_field"><label class="frm-style-item-heading"><?php esc_html_e( 'Padding', 'formidable' ); ?></label></div>
<div class="frm5 frm_form_field"><?php FrmSliderStyleComponent::style_item_heading( $style, 'form_desc_padding', 'frm_form_desc_padding-value', __( 'Padding', 'formidable' ) ); ?></div>

@deepsource-io deepsource-io Bot Oct 1, 2026

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Variable $style might not be defined


A variable has been used but not defined, which may result in warnings during program execution. This can also cause bugs since the intended usage scope of the variable is not known.

@deepsource-io deepsource-io Bot Oct 1, 2026

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Variable $style might not be defined


A variable has been used but not defined, which may result in warnings during program execution. This can also cause bugs since the intended usage scope of the variable is not known.

<div class="frm7 frm_form_field">
<?php
new FrmSliderStyleComponent(
Expand Down
6 changes: 2 additions & 4 deletions classes/views/styles/_form-messages.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -72,8 +72,7 @@ class="frm-style-item-heading"><?php esc_html_e( 'Font Color', 'formidable' ); ?
</div>

<div class="frm5 frm_form_field">
<label
class="frm-style-item-heading"><?php esc_html_e( 'Font Size', 'formidable' ); ?></label>
<?php FrmSliderStyleComponent::style_item_heading( $style, 'success_font_size', 'frm_success_font_size-value', __( 'Font Size', 'formidable' ) ); ?>

@deepsource-io deepsource-io Bot Oct 1, 2026

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Variable $style might not be defined


A variable has been used but not defined, which may result in warnings during program execution. This can also cause bugs since the intended usage scope of the variable is not known.

@deepsource-io deepsource-io Bot Oct 1, 2026

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Variable $style might not be defined


A variable has been used but not defined, which may result in warnings during program execution. This can also cause bugs since the intended usage scope of the variable is not known.

</div>
<div class="frm7 frm_form_field">
<?php
Expand Down Expand Up @@ -147,8 +146,7 @@ class="frm-style-item-heading"><?php esc_html_e( 'Font Color', 'formidable' ); ?
</div>

<div class="frm5 frm_form_field">
<label
class="frm-style-item-heading"><?php esc_html_e( 'Font Size', 'formidable' ); ?></label>
<?php FrmSliderStyleComponent::style_item_heading( $style, 'error_font_size', 'frm_error_font_size-value', __( 'Font Size', 'formidable' ) ); ?>

@deepsource-io deepsource-io Bot Oct 1, 2026

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Variable $style might not be defined


A variable has been used but not defined, which may result in warnings during program execution. This can also cause bugs since the intended usage scope of the variable is not known.

@deepsource-io deepsource-io Bot Oct 1, 2026

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Variable $style might not be defined


A variable has been used but not defined, which may result in warnings during program execution. This can also cause bugs since the intended usage scope of the variable is not known.

</div>
<div class="frm7 frm_form_field">
<?php
Expand Down
6 changes: 2 additions & 4 deletions classes/views/styles/_form-title.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -22,8 +22,7 @@ class="frm-style-item-heading"><?php esc_html_e( 'Color', 'formidable' ); ?></la
</div>

<div class="frm5 frm_form_field">
<label
class="frm-style-item-heading"><?php esc_html_e( 'Font Size', 'formidable' ); ?></label>
<?php FrmSliderStyleComponent::style_item_heading( $style, 'title_size', 'frm_title_size-value', __( 'Font Size', 'formidable' ) ); ?>

@deepsource-io deepsource-io Bot Oct 1, 2026

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Variable $style might not be defined


A variable has been used but not defined, which may result in warnings during program execution. This can also cause bugs since the intended usage scope of the variable is not known.

@deepsource-io deepsource-io Bot Oct 1, 2026

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Variable $style might not be defined


A variable has been used but not defined, which may result in warnings during program execution. This can also cause bugs since the intended usage scope of the variable is not known.

</div>
<div class="frm7 frm_form_field">
<?php
Expand All @@ -39,8 +38,7 @@ class="frm-style-item-heading"><?php esc_html_e( 'Font Size', 'formidable' ); ?>
</div>

<div class="frm5 frm_form_field">
<label
class="frm-style-item-heading"><?php esc_html_e( 'Margin', 'formidable' ); ?></label>
<?php FrmSliderStyleComponent::style_item_heading( $style, 'title_margin_top', 'frm_title_margins-value', __( 'Margin', 'formidable' ) ); ?>

@deepsource-io deepsource-io Bot Oct 1, 2026

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Variable $style might not be defined


A variable has been used but not defined, which may result in warnings during program execution. This can also cause bugs since the intended usage scope of the variable is not known.

@deepsource-io deepsource-io Bot Oct 1, 2026

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Variable $style might not be defined


A variable has been used but not defined, which may result in warnings during program execution. This can also cause bugs since the intended usage scope of the variable is not known.

</div>
<div class="frm7 frm_form_field">
<?php
Expand Down
12 changes: 3 additions & 9 deletions classes/views/styles/_general.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -64,9 +64,7 @@ class="frm-style-item-heading"><?php esc_html_e( 'Border Color', 'formidable' );
</div>

<div class="frm5 frm_form_field">
<label
for="frm_fieldset"
class="frm-style-item-heading"><?php esc_html_e( 'Border Width', 'formidable' ); ?></label>
<?php FrmSliderStyleComponent::style_item_heading( $style, 'fieldset', 'frm_fieldset-value', __( 'Border Width', 'formidable' ) ); ?>

@deepsource-io deepsource-io Bot Oct 1, 2026

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Variable $style might not be defined


A variable has been used but not defined, which may result in warnings during program execution. This can also cause bugs since the intended usage scope of the variable is not known.

@deepsource-io deepsource-io Bot Oct 1, 2026

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Variable $style might not be defined


A variable has been used but not defined, which may result in warnings during program execution. This can also cause bugs since the intended usage scope of the variable is not known.

</div>
<div class="frm7 frm_form_field">
<?php
Expand All @@ -82,9 +80,7 @@ class="frm-style-item-heading"><?php esc_html_e( 'Border Width', 'formidable' );
</div>

<div class="frm5 frm_form_field">
<label
for="frm_fieldset_padding"
class="frm-style-item-heading"><?php esc_html_e( 'Padding', 'formidable' ); ?></label>
<?php FrmSliderStyleComponent::style_item_heading( $style, 'fieldset_padding', 'frm_fieldset_padding-value', __( 'Padding', 'formidable' ) ); ?>

@deepsource-io deepsource-io Bot Oct 1, 2026

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Variable $style might not be defined


A variable has been used but not defined, which may result in warnings during program execution. This can also cause bugs since the intended usage scope of the variable is not known.

@deepsource-io deepsource-io Bot Oct 1, 2026

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Variable $style might not be defined


A variable has been used but not defined, which may result in warnings during program execution. This can also cause bugs since the intended usage scope of the variable is not known.

</div>
<div class="frm7 frm_form_field">
<?php
Expand All @@ -101,9 +97,7 @@ class="frm-style-item-heading"><?php esc_html_e( 'Padding', 'formidable' ); ?></
</div>

<div class="frm5 frm_form_field">
<label
for="frm_form_width"
class="frm-style-item-heading"><?php esc_html_e( 'Form Width', 'formidable' ); ?></label>
<?php FrmSliderStyleComponent::style_item_heading( $style, 'form_width', 'frm_form_width-value', __( 'Form Width', 'formidable' ) ); ?>

@deepsource-io deepsource-io Bot Oct 1, 2026

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Variable $style might not be defined


A variable has been used but not defined, which may result in warnings during program execution. This can also cause bugs since the intended usage scope of the variable is not known.

@deepsource-io deepsource-io Bot Oct 1, 2026

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Variable $style might not be defined


A variable has been used but not defined, which may result in warnings during program execution. This can also cause bugs since the intended usage scope of the variable is not known.

</div>
<div class="frm7 frm_form_field">
<?php
Expand Down
12 changes: 4 additions & 8 deletions classes/views/styles/_quick-settings.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -127,8 +127,7 @@ class="frm-style-item-heading"><?php esc_html_e( 'Button Text', 'formidable' );
<hr class="frm12"/>

<div class="frm5 frm_form_field">
<label
class="frm-style-item-heading"><?php esc_html_e( 'Vertical Spacing', 'formidable' ); ?></label>
<?php FrmSliderStyleComponent::style_item_heading( $style, 'field_margin', 'frm_style_qsettings_field_margin-value', __( 'Vertical Spacing', 'formidable' ) ); ?>
</div>
<div class="frm7 frm_form_field">
<?php
Expand All @@ -147,8 +146,7 @@ class="frm-style-item-heading"><?php esc_html_e( 'Vertical Spacing', 'formidable
</div>

<div class="frm5 frm_form_field">
<label
class="frm-style-item-heading"><?php esc_html_e( 'Input Field Padding', 'formidable' ); ?></label>
<?php FrmSliderStyleComponent::style_item_heading( $style, 'field_pad', 'frm_style_qsettings_field_pad-value', __( 'Input Field Padding', 'formidable' ) ); ?>
</div>
<div class="frm7 frm_form_field">
<?php
Expand All @@ -167,8 +165,7 @@ class="frm-style-item-heading"><?php esc_html_e( 'Input Field Padding', 'formida
</div>
<hr class="frm12"/>
<div class="frm5 frm_form_field">
<label
class="frm-style-item-heading"><?php esc_html_e( 'Base Font Size', 'formidable' ); ?></label>
<?php FrmSliderStyleComponent::style_item_heading( $style, 'base_font_size', 'frm_base_font_size-value', __( 'Base Font Size', 'formidable' ) ); ?>
</div>
<div class="frm7 frm_form_field">
<?php
Expand Down Expand Up @@ -209,8 +206,7 @@ class="frm-style-item-heading"><?php esc_html_e( 'Field Shape', 'formidable' );
</div>

<div class="frm5 frm_form_field frm_hidden" data-frm-element="field-shape-corner-radius">
<label
class="frm-style-item-heading"><?php esc_html_e( 'Corner Radius', 'formidable' ); ?></label>
<?php FrmSliderStyleComponent::style_item_heading( $style, 'border_radius', 'frm_style_qsettings_border_radius-value', __( 'Corner Radius', 'formidable' ) ); ?>
</div>
<div class="frm7 frm_form_field frm_hidden frm-md-z-index" data-frm-element="field-shape-corner-radius">
<?php
Expand Down
Loading