Skip to content

Improve subfield error handling - #3489

Open
Crabcyborg wants to merge 11 commits into
masterfrom
improve_subfield_error_handling
Open

Crabcyborg wants to merge 11 commits into
masterfrom
improve_subfield_error_handling

Keep server errors on other combo sub fields when one changes

5164e8d
Select commit
Loading
Failed to load commit list.
Codecov / codecov/project succeeded Oct 1, 2026 in 1s

29.08% (+0.38%) compared to b6e7cf8

View this Pull Request on Codecov

29.08% (+0.38%) compared to b6e7cf8

Details

Codecov Report

❌ Patch coverage is 72.72727% with 15 lines in your changes missing coverage. Please review.
✅ Project coverage is 29.08%. Comparing base (b6e7cf8) to head (5164e8d).
⚠️ Report is 22 commits behind head on master.

Files with missing lines Patch % Lines
classes/models/fields/FrmFieldCombo.php 85.71% 5 Missing ⚠️
...ses/controllers/FrmEntriesAJAXSubmitController.php 42.85% 4 Missing ⚠️
classes/controllers/FrmComboFieldsController.php 0.00% 3 Missing ⚠️
classes/helpers/FrmFieldsHelper.php 71.42% 2 Missing ⚠️
classes/controllers/FrmFieldsController.php 66.66% 1 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff              @@
##             master    #3489      +/-   ##
============================================
+ Coverage     28.70%   29.08%   +0.38%     
- Complexity    12322    12361      +39     
============================================
  Files           211      212       +1     
  Lines         41410    41504      +94     
============================================
+ Hits          11885    12070     +185     
+ Misses        29525    29434      -91     

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.