Skip to content

Keep the submit button last when adding fields in the builder #3566

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
Crabcyborg merged 2 commits into from
Oct 13, 2026
Merged

Keep the submit button last when adding fields in the builder #3566

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
e927e9e
Keep the submit button last when adding fields in the builder
truongwp Oct 10, 2026
4911ee8
Merge branch 'master' into fix/submit-field-order-after-adding-field
Crabcyborg Oct 13, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion js/formidable_admin.js
View file
Open in desktop

Large diffs are not rendered by default.

13 changes: 6 additions & 7 deletions js/src/admin/admin.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2337,7 +2337,6 @@ window.frmAdminBuildJS = function() {
}
}
$placeholder.replaceWith( replaceWith );
updateFieldOrder();
afterAddField( msg, false );
if ( $siblings.length ) {
syncLayoutClasses( $siblings.first() );
Expand Down Expand Up @@ -3154,7 +3153,6 @@ window.frmAdminBuildJS = function() {
resolve( msg );

setTimeout( () => {
updateFieldOrder();
afterAddField( msg, true );

const fieldId = checkMsgForFieldId( msg );
Expand Down Expand Up @@ -3288,7 +3286,6 @@ window.frmAdminBuildJS = function() {
makeDraggable( replaceWith.get( 0 ).querySelector( 'li.form-field' ), '.frm-move' );
}

updateFieldOrder();
afterAddField( msg, false );
maybeDuplicateUnsavedSettings( fieldId, msg );
toggleOneSectionHolder( replaceWith.find( '.start_divider' ) );
Expand Down Expand Up @@ -3660,20 +3657,22 @@ window.frmAdminBuildJS = function() {
}
}

if ( msg.includes( 'frm-collapse-page' ) ) {
renumberPageBreaks();
}

addClass( field, 'frm-newly-added' );
setTimeout( function() {
field.classList.remove( 'frm-newly-added' );
}, 1000 );

// The server moves the submit row below the new field in the database, using the highest saved order.
// Copy those orders so the inputs match the database, then renumber from the builder.
// The saved orders can be lower than the builder positions, and the submit row would end up above other fields.
const lastRowOrderInput = field.querySelector( '#frm-last-row-fields-order' );
if ( lastRowOrderInput ) {
updateLastRowFieldsOrder( JSON.parse( lastRowOrderInput.value ) );
}

// This also renumbers page breaks.
updateFieldOrder();

if ( addFocus ) {
const bounding = field.getBoundingClientRect();
const container = document.getElementById( 'post-body-content' );
Expand Down
Loading