Skip to content

Fall back to the default style when a form's style was deleted #3610

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
Crabcyborg merged 2 commits into from
Oct 27, 2026
Merged

Fall back to the default style when a form's style was deleted #3610

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
8dfea06
Add failing test: deleted style should fall back to the default style…
vivi-the-going-merry[bot] Oct 23, 2026
45e57f6
Fall back to the default style class when the form's style was deleted
vivi-the-going-merry[bot] Oct 23, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions classes/controllers/FrmStylesController.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1348,6 +1348,11 @@ public static function get_form_style_class( $class, $style ) {
$frm_style = new FrmStyle( $style );
$style = $frm_style->get_one();

if ( ! $style ) {
// The style was deleted, so use the default style.
$style = ( new FrmStyle( 'default' ) )->get_one();
}

if ( $style ) {
$class .= ' frm_style_' . $style->post_name;
self::maybe_add_rtl_class( $style, $class );
Expand Down
12 changes: 12 additions & 0 deletions tests/phpunit/styles/test_FrmStylesController.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -185,4 +185,16 @@ public function test_save() {
$updated_style = $frm_style->get_one();
$this->assertSame( $style->post_title . ' Updated', $updated_style->post_title );

@deepsource-io deepsource-io Bot Oct 23, 2026

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Call to an undefined method test_FrmStylesController::assertSame()


The method you are trying to call is not defined, which can result in a fatal error.

}

public function test_get_form_style_class_falls_back_to_default_style_when_style_is_deleted() {
$default_style = ( new FrmStyle( 'default' ) )->get_one();
$this->assertNotEmpty( $default_style );

@deepsource-io deepsource-io Bot Oct 23, 2026

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Call to an undefined method test_FrmStylesController::assertNotEmpty()


The method you are trying to call is not defined, which can result in a fatal error.


$deleted_style_id = $default_style->ID + 100000;
$this->assertNull( ( new FrmStyle( $deleted_style_id ) )->get_one() );

@deepsource-io deepsource-io Bot Oct 23, 2026

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Call to an undefined method test_FrmStylesController::assertNull()


The method you are trying to call is not defined, which can result in a fatal error.


$class = FrmStylesController::get_form_style_class( ' with_frm_style', $deleted_style_id );

$this->assertSame( ' with_frm_style frm_style_' . $default_style->post_name, $class );

@deepsource-io deepsource-io Bot Oct 23, 2026

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Call to an undefined method test_FrmStylesController::assertSame()


The method you are trying to call is not defined, which can result in a fatal error.

}
}
Loading