Skip to content

Point list-forms description at list-entries - #3621

Merged
Crabcyborg merged 1 commit into
masterfrom
fix/issue-6858-list-forms-description
Oct 26, 2026
Merged

Crabcyborg merged 1 commit into
masterfrom
fix/issue-6858-list-forms-description

Conversation

@vivi-the-going-merry

Copy link
Copy Markdown
Contributor

Fixes Strategy11/formidable-pro#6858

Broken: the list-forms ability description told callers to use the form key for create-entry, which Lite doesn't register (Pro only).

Changed: description now names list-entries instead; list-fields and get-form kept.

Verified: php -l clean. No test asserts this string (grep of tests/), so none added. Single-string change, no CI-behavior impact.

🤖 Generated with Claude Code

Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>
@coderabbitai

coderabbitai Bot commented Oct 26, 2026

Copy link
Copy Markdown
Contributor

Important

Review skipped

Bot user detected.

To trigger a single review, invoke the @coderabbitai review command.

Run configuration

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

  • 🔍 Trigger review
  • Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@deepsource-io

deepsource-io Bot commented Oct 26, 2026 •

Copy link
Copy Markdown

DeepSource Code Review

We reviewed changes in a0b9742...3f24e58 on this pull request. Below is the summary for the review, and you can see the individual issues we found as inline review comments.

See full review on DeepSource ↗

PR Report Card

Overall Grade   Security  

Reliability  

Complexity  

Hygiene  

Code Review Summary

Analyzer Status Updated (UTC) Details
PHP Oct 26, 2026 4:26p.m. Review ↗
JavaScript Oct 26, 2026 4:26p.m. Review ↗

Important

AI Review is run only on demand for your team. We're only showing results of static analysis review right now. To trigger AI Review, comment @deepsourcebot review on this thread.

@franky-the-going-merry franky-the-going-merry Bot added the franky-working Franky is actively reviewing this label Oct 26, 2026

@franky-the-going-merry franky-the-going-merry Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approve: one-string change, correct against Lite.

  • list-entries is registered on Lite (FrmAbilitiesEntriesController, listed in test_FrmAbilitiesContract.php); create-entry is Pro only (only mentioned in FrmMcpAbilityRegistry). The description now names only Lite abilities, as the issue (formidable-pro#6858) asks. list-fields and get-form kept.
  • list-entries takes form_id as ID or form_key, so "form_key or id" still reads true.
  • No test asserts this string (grepped tests/). php -l clean.
  • Psalm is red here but also fails on master at the base commit (a0b9742); this PR touches no code path.

Not run: no live before/after. The "bug" is a wrong word in a description string, checked by reading source, not by running an MCP client. Local PHPUnit not run; CI skipped the heavy jobs for this bot-authored PR.

@franky-the-going-merry franky-the-going-merry Bot removed franky-review franky-working Franky is actively reviewing this labels Oct 26, 2026

@Crabcyborg Crabcyborg left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚀

@Crabcyborg
Crabcyborg merged commit 0665cd1 into master Oct 26, 2026
59 of 60 checks passed
@Crabcyborg
Crabcyborg deleted the fix/issue-6858-list-forms-description branch October 26, 2026 17:03
@Crabcyborg Crabcyborg added this to the 7.1 milestone Oct 26, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant