You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
@wmertens
Good point, but then it's going to be a breaking change, right? While adding hasMore is not breaking anything, we're going to change the behavior of cursor a bit. That means all of those 3 changes would make strato-db v4.
I created a next branch for v4. So we could implement hasMore on there.
But I think maybe we can avoid breakage by returning the cursor twice, in the field named e.g. lastCursor? That one will always have the cursor for the last element, and cursor will keep the same semantics. Or is that too ugly and is the breaking change easy to handle in application code?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Small bugfix, bug found by @chiss2906