Repository navigation
fix(bootstrap): preserve project references - #126
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
The bootstrap scripts previously rewrote every
</Reference>tag as</ProjectReference>. That leftVintagestory.csprojmalformed when it contained unrelated assembly references. This change replaces only theVintagestoryLibreference, preserves sibling references, and parses the generated XML before continuing.The release version is 0.3.19 in
VERSION,OptimumConfig, and the README package examples.Validation
make build: bootstrap and Release build passed with 0 warnings and 0 errors.make check-patches: 68 text patches, 50 Cecil patches, and 22 runtime donor patches validated. No pending, unavailable, or conflicting patches.make check,make check-shaders, andbash -n scripts/bootstrap.shpassed.bootstrap.ps1; the XML rewrite preserved an unrelated reference.