Repository navigation
Color the scrollbar with the chosen accent - #763
Merged
Merged
Conversation
The scrollbar thumb was the only surface still spelling the Amber mid stop as a hex (#7e501e) instead of var(--color-vs), so it stayed brown whatever accent the player picked in Config. A test now refuses any brand stop written as a hex outside the @theme block.
Pixnop
added
bug
Zaldaryon
approved these changes
Oct 17, 2026
Zaldaryon
left a comment
Zaldaryon
left a comment
Collaborator
There was a problem hiding this comment.
Tested on head 7492c4c. Verified npm run typecheck, npm run lint:ci, npm run format:check, npm run test (all 296 test files pass), and npm run build:unpack. The scrollbar thumb follows the active accent preset as intended, and the test in tests/domain/accentColors.test.ts guards against hardcoded brand stops. Approving.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
On beta.14 the scrollbar does not follow the launcher's accent color.
applyAccentColor(src/renderer/src/utils/accentStyle.ts) sets--color-vsl,--color-vsand--color-vsdon the root for the preset chosen in Config, and every surface reads those variables, except the scrollbar thumb:styles.cssgave itbackground-color: #7e501e, the Amber mid stop written as a hex, so it stayed brown under any other accent. It now usesvar(--color-vs), the same stop as the Play button and the enabled toggles.A new test in
tests/domain/accentColors.test.tsrefuses any of the three brand stops spelled as a hex outside the@themeblock ofstyles.css. It fails on dev ("styles.css hard-codes #7e501e") and passes here; the scrollbar was the only such place. Prettier and ESLint are clean on both files.