fix (build) : Fixes build error due to 2GB default memory allocation to v8 engine (nodejs)#776
Open
vineetbambah wants to merge 2 commits intoStructuredLabs:mainfrom
Open
Conversation
Author
|
@BloggerBust @amrutha97 @shivam-singhal @jayanth-kumar-structuredlabs Can you review this PR? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Related Issue
Fixes #775
Description of Changes
I ran into the issue of not being able to build the repository for testing a few days back for which I myself added this issue to the issue board.
I tried to fix this issue on my own and realized that it was a nodejs issue. v8 engine by default has a cap of 2 GB which was overflowing and I added the NODE_OPTIONS to increase the assigned memory for that particular subprocess.
Type of Change
Testing

I initially ran the build process which lead to it being failed.
After checking the nodejs memory usage the issue was apparent and I went on to globally set the memory assigned to nodejs 4gb which fixed the issue.
After setting the environment variable there is a layer of abstraction that a new contributor doesn`t have to face to contribute.
Checklist