Fix check-deps-changed.sh matching the wrong release - #95
Merged
Merged
Conversation
…nged.sh gh release list's first column is the release title, and no real deps release is titled starting with "deps-v" (e.g. "VapourBox Dependencies 1.9.0") - only a one-off release literally titled "deps-v1.5.0 (test)" matched, so the script always compared against that stale release instead of the actual latest deps-v tag. Extract the tag column first, same as the working pattern already used in get-github-version.sh. Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01B7MZjvZntJ6Kb1aBvKjZnP
StuartCameronCode
added a commit
that referenced
this pull request
Sep 12, 2026
…tag-match Fix check-deps-changed.sh matching the wrong release
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
gh release list's output isTITLE<tab>STATUS<tab>TAG<tab>DATE.check-deps-changed.shwas matching^deps-v[0-9]against the raw line (i.e. the title), not the tag column.deps-v(they're "VapourBox Dependencies 1.9.0", "VapourBox deps 1.10.0", etc.) — only a one-off release literally titleddeps-v1.5.0 (test)ever matched, so the script always diffed against that stale June release instead of the actual latestdeps-v*tag (currently thedeps-v1.10.0draft).awk -F'\t' '{print $3}', the same patternget-github-version.shalready uses correctly.Found while manually checking whether the latest deps draft release was up to date with current code — the script's own answer for that question was wrong.
Test plan
./Scripts/check-deps-changed.sh --verbosenow reportsLast deps release: deps-v1.10.0(previouslydeps-v1.5.0) and correctly resolves its target commit.🤖 Generated with Claude Code
https://claude.ai/code/session_01B7MZjvZntJ6Kb1aBvKjZnP