fix(data): enforce canonical city slugs - #211
Merged
Merged
Conversation
Contributor
|
@AyobamiH is attempting to deploy a commit to the studentsuite Team on Vercel. A member of the Team first needs to authorize it. |
AyobamiH
force-pushed
the
fix/160-city-slug-validation
branch
from
September 6, 2026 00:20
d5e8615 to
2f7bd65
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
Closes #160.
City values are documented as lowercase, underscore-separated slugs, but the dataset contained four values outside that shape and one misspelling. The validator did not enforce the convention.
Changes
data/places.schema.json.validate-places.mjsenforce that schema-owned pattern.new_delhislug.Verification
npm run validatenpm run lintnpm run typechecknpm run test:unit(42 files, 377 tests)env -u NEXT_PUBLIC_MAPTILER_KEY npm run build(594 pages)npx prettier --check data/places.schema.json data/places/library.json data/places/sat_centre.json scripts/validate-places.mjsNew Delhiis rejected./city/xiamen,/city/new_delhi, and/city/philadelphiareturn 200.Known upstream check
The new full-repository
npm run format:checkcommand currently reports 127 pre-existing files on the unchanged upstream baseline. This PR does not include unrelated repository-wide formatting.