feat(competitions): logo banners on competition grid cards - #223
Merged
Conversation
Contributor
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Adds an optional
imagefield to the competition schema and renders a logo banner on the grid variant of the competition card.Changes
image(e.g."/competitions/xyz.png") added todata/competitions.schema.jsonandCompetitioninsrc/lib/types.tsnext/image,object-contain) that links out to the official site in a new tab; falls back to a trophy placeholder when no image existsimagepopulated for all 75 existing competition entries across the 15 category filespublic/competitions/next/imagemockVerification
npm run validate— all 15 competition files cleannpm run test:unit— 438 tests passnpm run typecheck— cleannpm run lint— cleannpm run build— passes