fix(data): replace 13 literal lat,lng gmaps_links (#229) - #235
Merged
Conversation
Contributor
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
…ates The 13 UK SAT centres in `sat_centre.json` still had `gmaps_link: "https://maps.google.com/?q=lat,lng"` from the record-shape template, while their `lat`/`lng` fields were correct. Fill each link with that record's own coordinates. Also harden `validate-places.mjs` so the same bug can't ship again: a `gmaps_link` that still contains the literal `lat,lng` placeholder now fails validation (it previously passed the URL-pattern check). Fixes #229 🤖 Generated with Codebuff Co-Authored-By: Codebuff <noreply@codebuff.com>
shauryagangrade
force-pushed
the
fix/229-fix-latlng-gmaps-links
branch
from
September 7, 2026 07:28
6738e72 to
c884b9f
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
gmaps_link: "https://maps.google.com/?q=lat,lng"placeholders insat_centre.jsonwith each record's own coordinates.gmaps_linkstill containing the rawlat,lngplaceholder now failsnpm run validate:places, instead of silently passing the URL-pattern check.Fixes #229
Validation
npm run validate:placespasses with 0 errors and 0 warnings on the affected file.Notes
scripts/fix-229-latlng-gmaps.mjswas used to do the replacement deterministically from the existinglat/lngvalues. It is a one-off fix script, not a long-lived tool, so I have not added it to the repo yet.🤖 Generated with Codebuff
Co-Authored-By: Codebuff noreply@codebuff.com