fix(data): resolve SAT centre data-quality issues and expand thin non-SAT categories - #238
Merged
Merged
Conversation
…sses, and expand thin place categories - Re-geocode 123 SAT centres sharing placeholder coordinates (#227, #234) - Add verified blocks to 122 corrected records (#231) - Remove duplicate same-location SAT centre (#232) - Fill addresses for 33 Canadian SAT centres (#230) - Add 38 hub airports plus library/gov/exam-centre places (#228)
Contributor
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
Keep both sets of additions: - foreign_lang_exam_centre: tor-01/tor-02 (mine) + main's ank/ist/ham/gur/rnc/bbs/abj records - gov_offices: main's van-01/ist-01 kept as-is; my Van City Hall & Istanbul Metro renumbered to -02 - library: main's ist-01 (Ataturk) kept; my Beyazit State Library renumbered to ist-02
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Resolves #227, #228, #230, #231, #232, #234.
Summary
Fixes all 6 open
owner-shauryadata-quality issues in the places dataset.#227 + #234 — Re-geocode placeholder coordinates
#231 — Re-verify corrected records
verifiedblock ({"by","on"}) to all 122 corrected records.#232 — Dedupe same-location centres
95890"Ozel Akar IEKFL" (identical physical address to59289).sat_centre.json: 609 → 608 records.#230 — Canadian addresses
addressfields for all 33 Canadian SAT centres that previously had none (incl. correcting two bad reverse-geocoded addresses).#228 — Thin non-SAT categories
Verification
npm run validate:places— all 6 files 0 errors.npm run typecheck— clean.npm run test:unit— 438 tests pass.Notes