refactor(gui): simplify delete-confirm overlay logic and deduplicate clamping#129
Merged
Merged
Conversation
…clamping - Add UiState::any_overlay_visible() to replace scattered OR checks - Extract clamp_selection_after_delete() to eliminate duplicated index logic - Move cx.notify() inside !showed_confirm branch to avoid redundant notification - Use .when() builder pattern in decorate_record_card instead of split let chain Refs #128
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Simplifies the delete-confirm dialog integration by extracting shared helpers and using idiomatic GPUI patterns, with no behavior change.
Linked Issue
Closes #128
Changes
UiState::any_overlay_visible()method to replace duplicatedclear_confirm_visible() || delete_confirm_visible()checksclamp_selection_after_delete()helper to deduplicate index-clamping logic inon_delete_recordandconfirm_pending_deletecx.notify()inside!showed_confirmbranch to avoid redundant notification when dialog already triggers oneletif/else builder split indecorate_record_cardwith idiomatic.when(!overlay_visible, ...)chainTesting
scripts/precheck.shpasses locallySelf-Check
thiserror(no manualimpl Display/Error)