Warn when an OnDeck file is missing from both cache and array#166
Merged
StudioNirin merged 1 commit intoMay 12, 2026
Merged
Conversation
When Plex reports an OnDeck/Watchlist item that is not present at either the cache pool path or /mnt/user0/, _get_move_command silently skipped it while the pre-move SUMMARY still claimed the planned size was cached. Promotes the skip to a WARNING that names both checked paths and the likely cause (non-default cache pool not mounted in the container). Defers the cache SUMMARY/cached_bytes computation until after move_media_files() runs and uses the actual queued bytes (last_cache_moves_bytes) so the SUMMARY line cannot diverge from [RESULTS] Moved to cache. Refs upstream issue StudioNirin#164.
StudioNirin
approved these changes
May 12, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Refs #164.
When Plex reports an OnDeck or Watchlist item that PlexCache can't physically locate at either the cache pool path or
/mnt/user0/,_get_move_commandpreviously skipped it silently while the pre-moveSUMMARYline still claimed the planned size was being cached. That made the run look successful even when 0 files actually moved.core/file_operations.py:_get_move_commandto aWARNINGthat names both checked paths and calls out the likely cause (a non-default cache pool that isn't mounted into the container).SUMMARY/cached_bytescomputation incore/app.pyuntil aftermove_media_files()returns, and sources it from the actual queued bytes (last_cache_moves_bytes) so theSUMMARYline can no longer diverge from[RESULTS] Moved to cache.Test plan
WARNINGper missing file, with both checked paths and the cache-pool hint.SUMMARYline's cached-bytes value matches[RESULTS] Moved to cache(no longer over-reports against actual moves).--dry-runand confirm the same warnings surface without any files being touched.