Community Apps version merging into main#172
Conversation
This XML file serves as a template for a Docker application, including metadata such as name, repository, support links, and version compatibility.
Updated container details for Plexcache-D, including name, repository, and overview. Changed WebUI port and deprecated status.
- templates/plexcache-d.xml: add the volume, port, and environment Config mappings (mirrors docker/plexcache-d.xml) so installs from the Apps store come pre-configured; add Icon/TemplateURL/donate fields, remove the doc skeleton comment, drop MaxVer, fix Overview wording - ca_profile.xml: close each example comment individually so the file is valid XML (libxml2 rejects '--' inside comments) - align template License with the MIT LICENSE.txt; remove the placeholder brackets in the copyright line
|
Pushed a commit ( What I changed
Two things I left for you to decide (no change beyond noting them)
Other things I noticed, left as-is
|
Brandon-Haney
left a comment
There was a problem hiding this comment.
Approving based on the reviewed file set plus the fixes in b9b6c8b:
templates/plexcache-d.xmlnow carries the full volume/port/env<Config>mappings, so a CA-store install comes up configured.ca_profile.xmlis valid XML (example comments closed individually).LICENSE.txtplaceholders removed.
Both XML files parse cleanly, the WebUI port (5757) matches the Dockerfile, and docker/icon.png resolves for the icon URLs.
Two non-blocking items left to your call (noted in the comment above): the MIT vs GPLv2 license choice, and the eventual consolidation of the two templates that now share the same Config blocks. Neither blocks this for the CA submission.
I just copied the License file directly from the example repo that unraid gives, which I guess was an MIT license. I didn't do anything except change the date and add a name. So I assume MIT is the correct one (as that's the one they give) though it's weird it references gplv2 elsewhere... I'll throw a question in the unraid chat and see if it matters.
I assume that the /templates one is required because the auto-check looks specifically for that folder, so yeh probably worth migrating our version over to it or making it reference it or whatever. Would be easier than remembering to keep them both updated. Probably best they're just identical files.
Yeh, I know we already had icons in another folder that everything already referenced. I assumed the one in the root folder though had to be there because the unraid CA auto-processing probably looks for it and maybe uses it as the icon in the CA store thumbnail. I assume that's the case anyway.
Yeh I don't know. Probably worthwhile making everything consistent, but then if we end up merging or whatever those two files it'll resolve itself anyway. @Brandon-Haney I'll go through the changes again and then merge this later and attempt to do the CA process. Thanks for correcting the template xml. I hadn't stopped to consider that was how the auto-dockerman fields got filled out, I had expected to do that separately at some point. I was clearly too tired when figuring this stuff out! |
Additions so that this could be submitted to the CA store:
I actually thought more was needed, but seems they have a new automation system that handles a lot of it, so none of this should be an issue. But as they seem to require an icon.svg in the main folder, there's probably no need to also have that file in the docker directory (?) though it's only a tiny file so no real benefit to removing it.