Skip to content

Community Apps version merging into main#172

Merged
StudioNirin merged 13 commits into
mainfrom
main-CA
Jun 3, 2026
Merged

Community Apps version merging into main#172
StudioNirin merged 13 commits into
mainfrom
main-CA

Conversation

@StudioNirin

@StudioNirin StudioNirin commented May 29, 2026

Copy link
Copy Markdown
Owner

Additions so that this could be submitted to the CA store:

  • LICENSE.txt
  • ca_profile.xml
  • icon.svg (in main folder)
  • /templates/plexcache-d.xml

I actually thought more was needed, but seems they have a new automation system that handles a lot of it, so none of this should be an issue. But as they seem to require an icon.svg in the main folder, there's probably no need to also have that file in the docker directory (?) though it's only a tiny file so no real benefit to removing it.

This XML file serves as a template for a Docker application, including metadata such as name, repository, support links, and version compatibility.
Updated container details for Plexcache-D, including name, repository, and overview. Changed WebUI port and deprecated status.
@StudioNirin StudioNirin requested a review from Brandon-Haney May 29, 2026 04:06
StudioNirin and others added 2 commits May 29, 2026 05:49
- templates/plexcache-d.xml: add the volume, port, and environment
  Config mappings (mirrors docker/plexcache-d.xml) so installs from the
  Apps store come pre-configured; add Icon/TemplateURL/donate fields,
  remove the doc skeleton comment, drop MaxVer, fix Overview wording
- ca_profile.xml: close each example comment individually so the file
  is valid XML (libxml2 rejects '--' inside comments)
- align template License with the MIT LICENSE.txt; remove the placeholder
  brackets in the copyright line
@Brandon-Haney

Copy link
Copy Markdown
Collaborator

Pushed a commit (b9b6c8b) with the changes below. Happy to revert or adjust any of it — flagging the two judgment calls explicitly so they're yours to make.

What I changed

templates/plexcache-d.xml

  • Added the volume / port / env <Config> mappings (mirrored from docker/plexcache-d.xml): /config, /mnt/cache, /mnt/user0, /mnt/user, PUID/PGID/TZ, port 5757, and the Unraid notification mounts. Without these, the CA-generated "Add Container" form had no paths or port, so an install from the Apps store would come up unconfigured and unable to see media.
  • Added <Icon>, <TemplateURL> (pointing at the templates/ copy), and the donate fields.
  • Removed the <!-- Delete this file if your repository does not ship Docker apps. --> skeleton comment (we do ship one).
  • Dropped <MaxVer>7.3</MaxVer> so it isn't flagged incompatible on Unraid 7.4+ (no known incompatibility to cap against).
  • Minor wording fix in <Overview> ("episodes.." → "episodes.").

ca_profile.xml

  • Closed each example comment on its own line. The previous block left several <!-- examples unclosed, which nested them and put -- inside a comment — that's invalid XML and libxml2 (what CA uses) rejects it. Verified the file now parses.

LICENSE.txt

  • Removed the template placeholders: Copyright (c) [2026] [Studio Nirin]Copyright (c) 2026 Studio Nirin.

Two things I left for you to decide (no change beyond noting them)

  1. License: MIT vs GPLv2. The template declared GPLv2 but the LICENSE.txt you added is MIT, so I set the template to MIT to match the file. If the project should stay GPLv2, the LICENSE.txt is the thing to swap instead — just let me know which way you want it.
  2. Two templates now carry the same Config blockstemplates/plexcache-d.xml and docker/plexcache-d.xml. They'll work, but they can drift over time. Might be worth picking one as canonical down the road (e.g. have docker/ reference the templates/ copy). Not urgent.

Other things I noticed, left as-is

  • The root icon.svg isn't referenced by anything yet — ca_profile.xml and both templates point at docker/icon.png (which exists, so icons resolve). You already called this out in the PR description; it's harmless, just unused.
  • docker/plexcache-d.xml uses <Shell>sh</Shell> while the new template uses bash — both are fine on the python:3.11-slim base, purely cosmetic.

@Brandon-Haney Brandon-Haney left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approving based on the reviewed file set plus the fixes in b9b6c8b:

  • templates/plexcache-d.xml now carries the full volume/port/env <Config> mappings, so a CA-store install comes up configured.
  • ca_profile.xml is valid XML (example comments closed individually).
  • LICENSE.txt placeholders removed.

Both XML files parse cleanly, the WebUI port (5757) matches the Dockerfile, and docker/icon.png resolves for the icon URLs.

Two non-blocking items left to your call (noted in the comment above): the MIT vs GPLv2 license choice, and the eventual consolidation of the two templates that now share the same Config blocks. Neither blocks this for the CA submission.

@StudioNirin

Copy link
Copy Markdown
Owner Author

Two things I left for you to decide (no change beyond noting them)

  1. License: MIT vs GPLv2. The template declared GPLv2 but the LICENSE.txt you added is MIT, so I set the template to MIT to match the file. If the project should stay GPLv2, the LICENSE.txt is the thing to swap instead — just let me know which way you want it.

I just copied the License file directly from the example repo that unraid gives, which I guess was an MIT license. I didn't do anything except change the date and add a name. So I assume MIT is the correct one (as that's the one they give) though it's weird it references gplv2 elsewhere... I'll throw a question in the unraid chat and see if it matters.

  1. Two templates now carry the same Config blockstemplates/plexcache-d.xml and docker/plexcache-d.xml. They'll work, but they can drift over time. Might be worth picking one as canonical down the road (e.g. have docker/ reference the templates/ copy). Not urgent.

I assume that the /templates one is required because the auto-check looks specifically for that folder, so yeh probably worth migrating our version over to it or making it reference it or whatever. Would be easier than remembering to keep them both updated. Probably best they're just identical files.

Other things I noticed, left as-is

  • The root icon.svg isn't referenced by anything yet — ca_profile.xml and both templates point at docker/icon.png (which exists, so icons resolve). You already called this out in the PR description; it's harmless, just unused.

Yeh, I know we already had icons in another folder that everything already referenced. I assumed the one in the root folder though had to be there because the unraid CA auto-processing probably looks for it and maybe uses it as the icon in the CA store thumbnail. I assume that's the case anyway.

  • docker/plexcache-d.xml uses <Shell>sh</Shell> while the new template uses bash — both are fine on the python:3.11-slim base, purely cosmetic.

Yeh I don't know. Probably worthwhile making everything consistent, but then if we end up merging or whatever those two files it'll resolve itself anyway.

@Brandon-Haney I'll go through the changes again and then merge this later and attempt to do the CA process. Thanks for correcting the template xml. I hadn't stopped to consider that was how the auto-dockerman fields got filled out, I had expected to do that separately at some point. I was clearly too tired when figuring this stuff out!

@StudioNirin StudioNirin merged commit 8c952a5 into main Jun 3, 2026
2 checks passed
@StudioNirin StudioNirin deleted the main-CA branch June 3, 2026 23:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants