Fix mobile table columns and log viewer toolbar (#187)#188
Open
Brandon-Haney wants to merge 2 commits into
Open
Fix mobile table columns and log viewer toolbar (#187)#188Brandon-Haney wants to merge 2 commits into
Brandon-Haney wants to merge 2 commits into
Conversation
The mobile breakpoint hid the first column of every table, which removed the selection checkbox from the Untracked Files and Orphaned Backups tables, leaving no way to select files on mobile. Drop the blanket first-column hide so the 40px checkbox column stays visible (tables already scroll within their container). Refs StudioNirin#187.
The time-range and toggle group in the log viewer toolbar used a non-wrapping flex row, so on narrow screens the Auto-scroll and Live Updates switches were pushed past the viewport and clipped by the card, leaving them unreachable. Add the flex-wrap utility so the group wraps to a second line when space runs out (no change on wider screens).
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Two mobile layout fixes.
1. Tables lost their first column on mobile (fixes #187)
The mobile breakpoint had a rule that hid the first column of every table on screens 768px and under. It was meant to drop a checkbox column for spacing, but it applied to all tables, so on a phone:
Removing the rule brings those columns back. The checkbox column is 40px and the tables already scroll inside their container, so spacing is fine.
2. Log viewer toolbar toggles were unreachable on mobile
The time-range and toggle group in the log viewer toolbar used a non-wrapping flex row. On narrow screens the Auto-scroll and Live Updates switches were pushed past the edge of the viewport and clipped by the card, so you could not reach them. Added the existing
flex-wraputility to that group so it wraps to a second line when space runs out. No change on wider screens.Test steps
Open the web UI on a phone, or use desktop browser devtools with a mobile viewport (around 390px wide).