Skip to content

[yumin-xia] ci(release): build with the tag's exact go.mod Go version #23

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
Stumble merged 1 commit into from
Nov 4, 2026
Merged

[yumin-xia] ci(release): build with the tag's exact go.mod Go version #23

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 5 additions & 2 deletions .github/workflows/release.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -25,8 +25,6 @@ concurrency:

env:
TAG: ${{ inputs.tag || github.ref_name }}
# Go release used for the binaries: the newest patch of go.mod's version.
GO_VERSION: "1.26"

jobs:
build:
Expand Down Expand Up @@ -54,6 +52,11 @@ jobs:
run: |
echo "$TAG" | grep -Eq '^v[0-9]+\.[0-9]+\.[0-9]+(-[0-9A-Za-z.]+)?$' || { echo "not a release tag: $TAG" >&2; exit 1; }
echo "VERSION=${TAG#v}" >> "$GITHUB_ENV"
# Go release used for the binaries: exactly the tag's go.mod version
# (a bare "1.26" can resolve to an older cached patch on the runner).
go_version="$(awk '$1 == "go" { print $2 }' go.mod)"
test -n "$go_version" || { echo "no go directive in go.mod" >&2; exit 1; }
echo "GO_VERSION=$go_version" >> "$GITHUB_ENV"
# Same version string as `make build` from the tag.
echo "LDFLAGS=-s -w -X github.com/sqlc-dev/sqlc/internal/info.Version=${TAG}-wicked-fork" >> "$GITHUB_ENV"

Expand Down
4 changes: 3 additions & 1 deletion docs/changelogs/2026-11-04-release-binaries.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -45,7 +45,9 @@ binaries for several platforms with an install script that checks the SHA-256.
- D3 The build steps live in the workflow, not the Makefile, so a manual run
can build tags older than this change (v2.4.0); the version flag matches the
Makefile's.
- D4 Go: newest patch of 1.26 (go.mod's version).
- D4 Go: exactly the tag's go.mod version (`go 1.26.10` for v2.4.1). The first
v2.4.1 run used `1.26`, which setup-go resolved to a cached 1.26.7 on
`macos-15-intel`; go.mod refused it.
- R1 GitHub runner labels (`macos-15-intel`, `ubuntu-24.04-arm`) are checked
only when the workflow first runs.

Expand Down
Loading