Skip to content

Fixed sound that could be heard from much too far away on certain maps. - #362

Open
Vitroze wants to merge 1 commit into
StyledStrike:mainfrom
Vitroze:fix/distancevolume
Open

Vitroze wants to merge 1 commit into
StyledStrike:mainfrom
Vitroze:fix/distancevolume

Conversation

@Vitroze

@Vitroze Vitroze commented Sep 16, 2026

Copy link
Copy Markdown
Contributor

On certain maps, the sound distance is far too great, meaning an approaching motorcycle can always be heard despite the already low volume. This PR fixes the issue.

Fix : #352

@Vitroze
Vitroze marked this pull request as ready for review September 16, 2026 22:56
@StyledStrike

Copy link
Copy Markdown
Owner

Manually calculating the attenuation is not the correct way to deal with this, plus it can cause confusion in the code given that it is applied on top of what the PannerNode is already doing.

@StyledStrike

Copy link
Copy Markdown
Owner

As for setting onload/onerror/onabort to null when removing the layer, that should probably done before the request is aborted, which I've done on b313df7

@Vitroze

Vitroze commented Sep 22, 2026

Copy link
Copy Markdown
Contributor Author

Manually calculating the attenuation is not the correct way to deal with this, plus it can cause confusion in the code given that it is applied on top of what the PannerNode is already doing.

I'll look into integrating another solution instead of creating the "attenuation."

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

WebAudio - Error Javascript

2 participants