Reactivate volunteer signups, focus on organizer role#589
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Merge after SuffolkLITLab/docassemble-DALVolunteerSignup#15
For the work-week: once we merge the volunteer form changes we can merge this too.
As the comment in the component says, I changed the button to a component mostly so it could send a url arg to the form. It's a bit overkill and we may never use it. If we wanted to use it, we could show different content (on the volunteer page and on the form) depending on the url arg. Thus people coming from "organizer" links might be shown more "open for business" type content and otherwise show people "we'll get in touch soon" type content. I'm doing a little of that now, but its only on the docs and not targeted at organizers specifically.
I wanted to go a little further and implement some of those other changes, but I may never get there. I can get rid of it if so desired.