Open
Conversation
Toilal
force-pushed
the
fonts-replace
branch
from
739d52b to
6bfc341
Compare
Contributor
Author
|
There's something wrong with the replacement, it's still a work in progress ... |
Toilal
force-pushed
the
fonts-replace
branch
2 times, most recently
from
79f9b07 to
aabb744
Compare
Toilal
force-pushed
the
fonts-replace
branch
from
aabb744 to
4767ab2
Compare
Contributor
Author
|
OK, i've change regexp to be stronger, should be ok now ! It works in my use case using bootstrap. |
Owner
|
I reopen this. Your solution seems great. I'm willing to merge this but you have to rebase it. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In distribution, fonts coming from bower dependencies are copied into
dist/fontsdirectory by thefontstask.Problem is that CSS can reference those fonts. There are some hardcoded cases based on frameworks supported by the generator, but it won't work for other libraries that user can add to bower later.
Using a regex in $.replace call, it will fix any bower_components fonts url and be consistent with
fontstask frombuild.js.