feat: wait for the VFS queue to be purged before unmounting - #95
Merged
Merged
Conversation
leafty
force-pushed
the
leafty/feat-purge-vfs-queue
branch
from
August 7, 2026 09:47
9840056 to
add99db
Compare
leafty
marked this pull request as ready for review
August 10, 2026 11:40
olevski
requested changes
Aug 11, 2026
leafty
force-pushed
the
leafty/feat-purge-vfs-queue
branch
from
August 14, 2026 07:36
1fc6315 to
50d2c66
Compare
leafty
force-pushed
the
leafty/feat-purge-vfs-queue
branch
from
August 14, 2026 07:37
50d2c66 to
a03a916
Compare
olevski
approved these changes
Aug 14, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #51.
When a
NodeUnpublishVolumerequest is received, wait for the VFS queue to be cleared before unmounting.This allows files to be synced to the remote and prevents losing data because the remote is unmounted before changes are synced.
Deployment: SwissDataScienceCenter/renku#4570 / https://ci-renku-4570.dev.renku.ch/