Repository navigation
Delete every path no live deployed app reaches (dead-code sweep round 4) - #767
Merged
Merged
Conversation
…, the gone demo Worker, test-only modules Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
…eys, acquisition and dev-only plugins Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
… scripts used Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
✅ Deploy Preview for rise-v2-symbolic-experience ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
…i links Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
sdcarlson
pushed a commit
that referenced
this pull request
Nov 4, 2026
Bring this branch up to date with main's dead-code sweeps (#765, #766, #767) so it can merge. Two files conflicted: - worker/mcp-server.mjs: main deleted Gate 0 and the witness log, made dispatch take the card as its third argument (dispatch(message, origin, card = null)) and deleted handleLive. All of that is kept as main has it. This branch's count callback becomes dispatch's fourth argument (count = () => {}): dispatch passes it to call() for rise_present, and handleMcp still derives the host with hostOf and writes through countEvent. No response changes. - vitest.fast.config.js: main lowered FAST_TEST_FILES from 169 to 157 after deleting test files, and this branch adds worker/telemetry.test.js. The merged list collects 158 files (vitest list --filesOnly, and the fast run's JSON report), so FAST_TEST_FILES is 158. PRIVACY.md, public/PRIVACY.md, public/privacy.html, worker/production-config.test.js and wrangler.production.jsonc merged without conflict; npm run verify:legal confirms the generated copies still match PRIVACY.md. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01VHrJ4hmTtR1RFNpc215EK7
sdcarlson
pushed a commit
that referenced
this pull request
Nov 4, 2026
Bring this branch up to date with main's dead-code sweeps (#765, #766, #767). It merges the updated telemetry/composer-counts (8f45346), which already merges main at bce75dc, so this one merge brings in both. Two files conflicted: - vitest.fast.config.js: #762's merge set FAST_TEST_FILES to 158, and this branch had raised it from 170 to 174 for its four test files. The merged list collects 162 files (vitest list --filesOnly, and the fast run's JSON report), so FAST_TEST_FILES is 162. - docs/specs/ARCHITECTURE.md: only the generated diagram conflicted. Took main's and regenerated it with npm run docs:diagram, which adds this branch's src/core/telemetry.js to core's module count and its imports to the audio, components and live edges into core. One break git could not see: main (#767) deleted worker/live-realtime.mjs, whose readText worker/count.mjs imports, and moved readText unchanged into worker/mcp-server.mjs as a private function. worker/mcp-server.mjs now exports it and worker/count.mjs imports it from there. It is the same function count.mjs used before, so the 512-byte and UTF-8 limits on a beacon are unchanged. PRIVACY.md, public/PRIVACY.md, public/privacy.html, src/audio/engine.js, src/audio/engine.lifecycle.test.js, src/components/Home.js, src/components/read/Chamber.js, src/core/error-boundary.js, src/live/host/LiveHost.js, src/live/host/LiveHost.test.js, worker/index.mjs, worker/production-config.test.js and wrangler.production.jsonc merged without conflict; npm run verify:legal confirms the generated legal copies still match PRIVACY.md. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01VHrJ4hmTtR1RFNpc215EK7
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Round 4 of the dead-code sweep, under a stricter rule from Seth: a path is dead if it isn't accessible from any live deployed app.
I walked the import graph from what is actually deployed (
index.html,enterprise.html,kev-check.html,wormhole.html,worker/index.mjs,worker/plus-preview.mjs) plus what builds, deploys and gates them. Code reached only by tests counted as dead. Each candidate was then checked by hand, because the analyzers were wrong in places.Removed
rise-chatgpt-democonfig and Gate 0: Wrangler reports that Worker no longer exists on the account./api/live/realtimewas off in every config.PRIVACY.mdloses its OpenAI Realtime paragraph and its date moves to 2 November 2026./library/journeysnow redirects to/library.kokoro-jsand@huggingface/transformers.Kept on purpose
rise-v2-symbolic-experience.netlify.appis live and builds frommain, sonetlify.toml, its function and their guards stay.tools/render: the owner closed Decision: remove render-mill (scripts) #330 to keep them, although the mill isn't reachable from a deployed app./enterpriseand/kev-check: both live.local/launcher anddeploy/kev: the live Home page tells readers to run RISE on their own computer.wrangler.staging.jsonc:rise-jev-previewstill exists behind Access.certifySequenceover the flash meter.Not deleted, needs a decision
IMAGE_STREAM_ENABLED = false): unreachable, but RDR-031 is in progress under its own owner.FLASHING_ENABLED = false): unreachable, but removing them means editing the photosensitivity kill switch, which should be its own reviewed change.Behaviour changes
/api/live/realtimeanswers the Worker's JSON 404 instead of 503./liveis served by the asset layer. POST/liveprobably changes from 405 to 404; this could not be tested on Cloudflare./live?provider=openaifalls back to the demo and says so.Restoring a tool
Authoring tools now live in git history. To bring one back:
a908c67cis the last commit before this change. Many docs underdocs/still mention these tools as history, and I did not rewrite them.Coverage lost
Unit tests went with their code, including acquisition's URL and rights refusals.
docs/specs/RISE-SDK.mdis no longer held to the code by a test. No browser test now covers Stop while connecting or literal passages over Realtime;src/live/literal.test.jsstill covers literal text at unit level.Verification
CIcheck on this exact commit: see the checks below.fit-mask-boundaries), 1 failed:e2e/home.spec.js:243, Home shows "By chance" instead of "Continue". Not from this change: repeated 6 times,maingave 2 failed and 1 flaky, this branch 1 failed and 2 flaky.ci-hygiene,roadmap:check,test:roadmap, thenode --testlist,deploy/kevPython tests,security:compat,build-wiki, Vite build, first-load budget, both Worker dry-run bundles.netlify.tomlalthough the Netlify site is live, and removed a Kev pindeploy/kevneeds. Both are restored here.🤖 Generated with Claude Code