Repository navigation
fix: generate native wp-config in the WordPress parent - #33
Merged
Merged
Conversation
brianvarskonst
commented
Oct 7, 2026
brianvarskonst
left a comment
Member
Author
There was a problem hiding this comment.
Review completed on c21ed87ce90b93dcf70d7d9a3010d3f87172a076.
Resolved findings:
- The installation pipeline still read the root
wp-config.php. Updated the real package installer, documentation example, consumer replay and privileged permission test to use or monitor the native Core-parent configuration. Both formerly failing WPackagist jobs now pass. - Native migration followed in-project root symlinks and treated dangling links as absent, allowing configuration replacement without an explicit migration. Both cases now fail before writes, with regression coverage preserving the source file, link, public proxy and payload artifacts.
- A retained
KEYSsection could contain__DIR__or__FILE__and silently change behavior when moved. Migration now refuses this code before writes. Edited literal salts still survive migration.
Local validation passed: coding standards, static analysis, 1,439 PHPUnit tests / 10,449 assertions with zero skips, real WordPress/MariaDB bootstrap, real Composer installs in both plugin modes, documented examples, privileged access checks, 14 Python tests, documentation validation and all 408 parity rows.
No unresolved findings remain in the reviewed changes.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Native Runtime now generates the main configuration directly in the WordPress Core parent. With Core in
public/wp, the only fresh configuration ispublic/wp-config.php; there is no root configuration or forwarding loader. WP-CLI, section editing, setup drift and production diagnostics resolve the same target. Legacy profiles and explicit invocation-context targets retain their behavior.Existing managed root configurations migrate without executing PHP or rotating literal authentication salts, including edited literal values. The original root file remains available for rollback. Edited managed sections, dynamic salts, location-dependent salt code and valid or dangling root symlinks require explicit migration before any configuration or payload is replaced. ADR 0029 documents the location change and migration procedure.
The real package-installation and documented-example checks now verify the public main configuration and the absence of a root file or proxy. Consumer replay monitors both native and retained root configurations. The privileged bootstrap test verifies the actual public configuration with separate PHP identities.
Validation:
composer qa: 1,439 tests, 10,449 assertions, zero skipped tests; coding standards and static analysis passed.