Open
Conversation
ddbaptiste
requested changes
Apr 3, 2026
Member
ddbaptiste
left a comment
ddbaptiste
left a comment
There was a problem hiding this comment.
There are some minor changes requested throughout that should go quickly.
It's a big lift to have all these copy/delete operators clearly defined, and I think you said this means we can build on Windows too?! Massive. Thanks for these changes!
Comment on lines
+41
to
+44
| HCVTreatment(const data::Inputs &inputs, const std::string &log) | ||
| : TreatmentBase("hcv_treatment", inputs, log) { | ||
| LoadData(); | ||
| } |
Member
There was a problem hiding this comment.
I think we lost the setting of cost/utility categories to treatment in the conversion. I couldn't keep track of all the categories throughout the big PR, so I might've missed other categories too.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Pretty hefty update:
What Wrike task is this associated with?
Checklist before merging