Repository navigation
feat(mcp): split OAuth endpoints and restrict directory tools - #22
Merged
Merged
Conversation
Drops the X-Synter-Key header and SYNTER_API_KEY variable; validator now enforces OAuth-only on both manifests.
|
Navigate logical layers of code changes, visualize relationships, and explore their blast radius. Note Currently processing new changes in this PR. This may take a few minutes, please wait... ⚙️ Run configurationConfiguration used: defaults Review profile: CHILL Plan: Advanced Run ID: 📒 Files selected for processing (89)
✨ Finishing Touches📝 Generate docstrings
🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
jshorwitz
changed the title
jshorwitz
marked this pull request as ready for review
October 2, 2026 17:08
jshorwitz
changed the base branch from
chore/cursor-marketplace-review-fixes
to
main
October 2, 2026 17:54
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This keeps Cursor and Claude on their approved OAuth endpoints and limits the plugin instructions to the 34-tool directory approved by Joel and Product on 2026-10-01.
Stacked on #21. Its current branch tip is already included in this branch; merging
origin/chore/cursor-marketplace-review-fixesreported “Already up to date.” Keep this PR draft until #21 merges and production OAuth readiness is verified. Retarget to main after #21 merges; this update does not merge either PR.https://mcp.synterai.comthroughmcp.json. Claude retainshttps://mcp.syntermedia.aiin.mcp.jsonto match the connector under Anthropic review. Manifest validation enforces the split and rejects static credential configuration, headers, and local server commands.create_ad_copy; asset selection useslist_creative_assets. GA4 references usega4_get_properties,ga4_get_report, andga4_get_conversions.tools/directory-tools.jsonwith exactly the approved 34 names and a GitHub Actions check for skills, optional commands, rules, and agents. The extractor covers prose, tables, examples, and MCP-qualified names, and rejects unlisted names and dynamic tool templates. An optional OAuth-token mode initializes an MCP session and checks paginated livetools/listresults at either production endpoint.Validation passed locally: manifest guards, all 59 instruction files against the directory, six validator tests, pinned strict Claude plugin validation, SDK and shell syntax checks, and the release zip build. Verified the zip’s endpoint split, 52 skills, and SDK exclusion; README local links and skill inventory also pass. Reviewed the requested repository-wide language scan; remaining matches are license wording, GitHub checkout actions, advertising-spend examples, and incidental substrings.
Live production
tools/listand headless OAuth session reuse were not exercised because no OAuth access token was available. Live protocol handling was tested with mocked JSON/SSE responses, session headers, pagination, and failure cases. This PR does not deploy the hosted server or establish production OAuth readiness.