Skip to content

Fix: Complete Cordiale E2E support for protocol 50 - #417

Merged
Sythos merged 3 commits into
mainfrom
enya/issue-416-complete-cordiale-e2e-support-for-protoc
Oct 24, 2026
Merged

Sythos merged 3 commits into
mainfrom
enya/issue-416-complete-cordiale-e2e-support-for-protoc

Conversation

@Sythos

@Sythos Sythos commented Oct 24, 2026 •

Copy link
Copy Markdown
Owner

Part of #416

This pull request does not include:

  • Add the claim route POST /e2e/devices/:did/claim and the copies route POST /e2e/devices/:did/copies with request and response types.
  • Add the protocol 50 inbox row own flag and the error tokens same_device, keyless_device, key_taken, removed_device and inbox_full.
  • Replace the candidate S1 rules in e2e_selfcopy.rs with the protocol 50 contract and add the receiveCopy path.
  • Finish the global KEYS limit, send-dropped reasons, queue limits and expiry rules from the final contract (item 4).
  • Complete the X1 pairing flow, the X2 revoke and reset flow, and the state migration (items 2, 3, 5 and 6).
  • Re-read the truncated item 7 and the final checks of the issue, then close the issue only when all checks pass.

@Sythos Sythos self-assigned this Oct 24, 2026
@Sythos Sythos added the Enya: check review PR: checks are green, waiting for reviews label Oct 24, 2026
@chatgpt-codex-connector

chatgpt-codex-connector Bot commented Oct 24, 2026 •

Copy link
Copy Markdown

Codex Review Summary

This comment shows the latest Codex review activity on this pull request.

Review Status Commit Review trigger
📝 Code Review ✅ Completed 2026-10-24T09:51:17.641257Z c17be95 Manual request
ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review" or "@codex security review".

Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings.

@Sythos Sythos added Enya: reviewed PR: reviews handled, waiting for the merge worker Enya: reworking PR: one or more checks failed, the fix is in progress and removed Enya: check review PR: checks are green, waiting for reviews labels Oct 24, 2026
@Sythos

Sythos commented Oct 24, 2026

Copy link
Copy Markdown
Owner Author

@codex review

@chatgpt-codex-connector

Copy link
Copy Markdown

Codex Review: Didn't find any major issues. 👍

Reviewed commit: c17be957b2

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Enya: reviewed PR: reviews handled, waiting for the merge worker

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant