Skip to content

Fix: Migrate device lists signed over the old raw byte order - #448

Merged
Sythos merged 2 commits into
mainfrom
enya/issue-430-migrate-device-lists-signed-over-the-old
Oct 24, 2026
Merged

Sythos merged 2 commits into
mainfrom
enya/issue-430-migrate-device-lists-signed-over-the-old

Conversation

@Sythos

@Sythos Sythos commented Oct 24, 2026

Copy link
Copy Markdown
Owner

Closes #430

This pull request does not include:

  • Sign the own list again with the master key when it verifies only in the old order. Keep the same version and the same keys.
  • Add the list_order function to e2e_list_migration.rs. Add migrate_own_list, which gives an error and does not sign when the list verifies in no order.
  • Add the Serialize and Deserialize derives to SignedList in e2e_manage.rs.
  • Store the pending signed list and a "migration done" flag in the sealed E2E state, in one write. The flag keeps the migration from running again after a restart.
  • Add tests for the own list. They cover the version, a list in the current order, a list that verifies in no order, a wrong signing key, and a restart.
  • Publish the pending list through the list route, and then clear it from the state.

@Sythos Sythos self-assigned this Oct 24, 2026
@Sythos Sythos added the Enya: check review PR: checks are green, waiting for reviews label Oct 24, 2026
@chatgpt-codex-connector

chatgpt-codex-connector Bot commented Oct 24, 2026 •

Copy link
Copy Markdown

Codex Review Summary

This comment shows the latest Codex review activity on this pull request.

Review Status Commit Review trigger
📝 Code Review ✅ Completed 2026-10-24T16:06:58.998374Z 78ed727 PR opened
ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review" or "@codex security review".

Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings.

@Sythos Sythos added Enya: reviewed PR: reviews handled, waiting for the merge worker and removed Enya: check review PR: checks are green, waiting for reviews labels Oct 24, 2026
@Sythos
Sythos merged commit 0126565 into main Oct 24, 2026
9 checks passed
@Sythos
Sythos deleted the enya/issue-430-migrate-device-lists-signed-over-the-old branch October 24, 2026 16:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Enya: reviewed PR: reviews handled, waiting for the merge worker

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Migrate device lists signed over the old raw byte order

1 participant