Skip to content

Update to 1.17#11

Open
CrashCringle12 wants to merge 1 commit intoTBMCPlugins:masterfrom
CrashCringle12:master
Open

Update to 1.17#11
CrashCringle12 wants to merge 1 commit intoTBMCPlugins:masterfrom
CrashCringle12:master

Conversation

@CrashCringle12
Copy link

I spent a few hours attempting to update the plugin to work on 1.17.

From my trials it works for my purposes and was able to load custom dimensions but there are still a few errors.

One thing I couldn't figure out was how to convert this line

var dimRegistry = ((RegistryMaterials<DimensionManager>) console.customRegistry.a());

This is what i had in there just to remove the error, merely just a placeholder

RegistryMaterials<DimensionManager> dimRegistry = new RegistryMaterials<DimensionManager>(null, null);

Uh I realize I changed the pom.xml and added another file, really that's just to show what i was working with and what was done on my end to have it functioning.

There's still some bugs but it works for my purposes
@NorbiPeti
Copy link
Member

NorbiPeti commented Jul 9, 2021

Thanks for the PR! However, it seems like custom dimensions are already being loaded by the server on 1.17(.1) Spigot without the plugin, was that not the case when you were testing it?

@DecisiveDolphin
Copy link

DecisiveDolphin commented Jan 11, 2022

I spent a few hours attempting to update the plugin to work on 1.17.

From my trials it works for my purposes and was able to load custom dimensions but there are still a few errors.

One thing I couldn't figure out was how to convert this line

var dimRegistry = ((RegistryMaterials<DimensionManager>) console.customRegistry.a());

This is what i had in there just to remove the error, merely just a placeholder

RegistryMaterials<DimensionManager> dimRegistry = new RegistryMaterials<DimensionManager>(null, null);

Uh I realize I changed the pom.xml and added another file, really that's just to show what i was working with and what was done on my end to have it functioning.

Howdy folks,

Sorry to disrupt this convo a bit; were you at least semi-successful in doing this CrashCringle? I've tried decompiling the jar to check it out myself, but it's beyond me as a learning Java student. Almost motivated to keep learning quite literally just to try and "crack" this jar file & update it to 1.17.1. (PaperMC).

Hopefully you're still alive out there, and hopefully if you're willing, you could teach me the route you took to do this!

P.S. If possible, PLEASE send me the 1.17(.1) jar!

@NorbiPeti
Copy link
Member

Hey @DecisiveDolphin! Spigot 1.17 (and its forks) should have custom dimension support. Have you tried adding the datapack in your main world and seeing if it works? I wanted to update the plugin but then focused on other things once I realized it's not necessary. However, I have been thinking on a version that updates existing dimensions to the vanilla stuff (which is just moving the dimension data around).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants