Fix misleading weekly reward previews - #80
Conversation
|
Navigate logical layers of code changes, visualize relationships, and explore their blast radius. No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Advanced Run ID: 📒 Files selected for processing (4)
Included review availability: This review used your included allowance. Your plan provides up to 10 included reviews per hour; 8 remain after this review. 📝 WalkthroughWalkthroughWeekly-reward lore now summarizes reward-pool options and shows previews for the next milestone. It uses configured pool eligibility to determine draw counts, limits the displayed options, and provides messages for unavailable previews and undisplayed options. ChangesWeekly Reward Preview
Priority: ⬇️ Low Estimated code review effort: 3 (Moderate) | ~20 minutes Change: Bug fix Suggested reviewers: Merge Risk: ⚪ Minimal · up to The previews summarize alternative rewards without an established payout change. The reported null lookup is unreachable; this change is mergeable subject to normal checks. 🚥 Pre-merge checks | ✅ 4 | ❌ 1❌ Failed checks (1 warning)
✅ Passed checks (4 passed)
Full details: Docstring CoverageExplanation Docstring coverage is 0.00% which is insufficient. The required threshold is 80.00%. Docstring coverage is scoped to functions touched by this diff. Analyzed 20 functions across 3 files. (1 skipped: 1 unsupported.)
✨ Finishing Touches 💡 1📝 Generate docstrings 💡
🧪 Generate unit tests (beta)
A rabbit counts the prizes bright, Comment |
The weekly reward tooltip lists every weighted entry, making alternative payouts look cumulative. Summarize amounts by item as a range (for example x2–8 Ignitium), and explicitly label the number of independent random draws and their alternatives.
The planned Act 1 pool fits in three material lines, with per-draw ranges of 20–80 Ignitium, 2–8 raw tin and 2–8 abyssalite fragments. Draw counts follow the multiplier pool whitelist; fixed rewards retain their multiplied amount. Command/bundle outcomes retain their descriptions, and large pools show at most four options plus a remaining count. No reward pools, probabilities or payouts change.
Validation:
mvn clean verify: 786 tests, no failures or skips.One random reward from:andx2–8 Ignitium, with the raw tier lines removed. Existing messages.yml works via packaged defaults.