Match activity lore wording to its amounts - #87
Conversation
Tasks needing one action or giving one point read "Cast 1 votes" and "Earn 1 activity points". Use the singular for an amount of 1, and "an" before Engineer/Animal Station. The description generator now picks the form from every/points, and knows the BreweryX activities. Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com>
|
Navigate logical layers of code changes, visualize relationships, and explore their blast radius. No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Advanced Run ID: 📒 Files selected for processing (3)
Included review availability: This review used your included allowance. Your plan provides up to 10 included reviews per hour; 9 remain after this review. 📝 SummarySummary by CodeRabbit
WalkthroughThe activity-description generator now selects singular or plural wording from configured amounts. The configuration contains revised activity descriptions, and a new test checks selected generated descriptions. ChangesActivity descriptions
Priority: ⬇️ Low Estimated code review effort: 2 (Simple) | ~10 minutes Change: Bug fix · Severity of issue fixed: Low Suggested reviewers: Merge Risk: ⚪ Minimal · up to Activity descriptions now use count-appropriate wording and include the added brewing entries. No actionable merge risk is supported by the reviewed evidence.
Comment |
Activity lore used fixed plurals, so tasks with
every: 1orpoints: 1read e.g. "Cast 1 votes for the server" and "Earn 1 activity points per completion".config.yml: singular wording where the amount is 1 (vote, injury, vehicle, faction battle, profession upgrade, Anvil item, "recipe 1 time", "1 activity point"), and "an Engineer/Animal Station".tools/update-activity-descriptions.py:{one|many}markers resolved fromevery/points(defaults 1/0, as inActivityConfiguration),a/anfrom the station name, and entries for the BreweryX activities (brew_ingredient,brew_bottle,brew_age,brew_drink), which previously made the generator fail.Regenerating the default config with the updated tool reproduces these descriptions for all 48 activities. Tool tests: 5 passed.
Live main/dev configs are hand-maintained and handled separately.
🤖 Generated with Claude Code