Skip to content

Match activity lore wording to its amounts - #87

Merged
JustinasLa merged 1 commit into
mainfrom
fix/activity-wording
Oct 1, 2026
Merged

JustinasLa merged 1 commit into
mainfrom
fix/activity-wording

Conversation

@JustinasLa

Copy link
Copy Markdown
Contributor

Activity lore used fixed plurals, so tasks with every: 1 or points: 1 read e.g. "Cast 1 votes for the server" and "Earn 1 activity points per completion".

  • Default config.yml: singular wording where the amount is 1 (vote, injury, vehicle, faction battle, profession upgrade, Anvil item, "recipe 1 time", "1 activity point"), and "an Engineer/Animal Station".
  • tools/update-activity-descriptions.py: {one|many} markers resolved from every/points (defaults 1/0, as in ActivityConfiguration), a/an from the station name, and entries for the BreweryX activities (brew_ingredient, brew_bottle, brew_age, brew_drink), which previously made the generator fail.
  • New test covering singular/plural and the article.

Regenerating the default config with the updated tool reproduces these descriptions for all 48 activities. Tool tests: 5 passed.

Live main/dev configs are hand-maintained and handled separately.

🤖 Generated with Claude Code

Tasks needing one action or giving one point read "Cast 1 votes" and
"Earn 1 activity points". Use the singular for an amount of 1, and "an"
before Engineer/Animal Station. The description generator now picks the
form from every/points, and knows the BreweryX activities.

Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com>
@coderabbitai

coderabbitai Bot commented Oct 1, 2026 •

Copy link
Copy Markdown

Review in Change Stack →

Navigate logical layers of code changes, visualize relationships, and explore their blast radius.

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Advanced

Run ID: 8baa9f5f-d56d-4c3e-ba2c-99f8a5103da0

📥 Commits

Reviewing files that changed from the base of the PR and between b4e3143 and f273b80.

📒 Files selected for processing (3)
  • src/main/resources/config.yml
  • tools/test_activity_descriptions.py
  • tools/update-activity-descriptions.py

Included review availability: This review used your included allowance. Your plan provides up to 10 included reviews per hour; 9 remain after this review.


📝 Summary

Summary by CodeRabbit

  • Improvements
    • Activity descriptions now use singular or plural wording that matches the number of completions, crafts, votes, injuries and activity points.
    • Engineer and Animal Station descriptions now use the correct articles (“an Engineer” and “an Animal”).
    • Brewing activities and station recipes now have consistent count-based wording, including descriptions for crafted items and coal-related activities.
    • Activity settings and behaviour are unchanged.

Walkthrough

The activity-description generator now selects singular or plural wording from configured amounts. The configuration contains revised activity descriptions, and a new test checks selected generated descriptions.

Changes

Activity descriptions

Layer / File(s) Summary
Description generation and validation
tools/update-activity-descriptions.py, tools/test_activity_descriptions.py
The generator adds count-sensitive wording and article selection for activity and recipe descriptions. The new test checks wording for vote, injury and Engineer descriptions.
Configured activity descriptions
src/main/resources/config.yml
Descriptions use singular forms for the listed single-count activities and activity points. The Engineer and Animal station descriptions use “an”.

Priority: ⬇️ Low

Estimated code review effort: 2 (Simple) | ~10 minutes

Change: Bug fix · Severity of issue fixed: Low

Suggested reviewers: xxfran10xx

Merge Risk: ⚪ Minimal · up to f273b

Activity descriptions now use count-appropriate wording and include the added brewing entries. No actionable merge risk is supported by the reviewed evidence.

  • Autopilot · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

Autopilot is currently an internal CodeRabbit preview.


Comment @coderabbitai help to get the list of available commands.

@JustinasLa
JustinasLa merged commit 78d1dc8 into main Oct 1, 2026
2 checks passed
@JustinasLa
JustinasLa deleted the fix/activity-wording branch October 1, 2026 14:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant