[ryanbarlow97]

Stage 6b (estates and wills, umbrella TF-Minecraft/RPCharacters#89): BarterShops becomes the bartershops estate participant.

Pause at death. Both trade directions refuse with "This shop's owner has died." while the owning character is not alive. An owner who cannot be read keeps the shop closed. A revived owner's shop trades again.

Transfer. When RPCharacters decides an estate, each shop owned by the testator goes to the property recipient, character and account, rewritten in place in Data/<shopId>.json through DurableFiles (the old saveShop always minted a new file, so it is not used here). A journal per death, estates/<deathId>.json, is written before the first shop changes, so a crash is finished at the next settle and DONE always carries every moved shop ID (design M12). Waiting and frozen property answers DONE with nothing moved. The participant acts only while Estates.guardHolds holds and the shop migration has finished. describe() lists the character's shops.

Leftover trades. A shop with a record in trades/ stays with the testator and the estate answers BLOCKED, naming it. The new staff command /bartershops intent <shopId> [clear [--confirm]] (bartershops.admin, audit-logged to logs/staff-audit.log) follows the design's P1 table: only a prepared record whose posting is absent or REFUSED clears without --confirm, and only while Denars.ready(); prepared + APPLIED, delivering, conflict and unreadable records are shown and need clear --confirm after staff act by hand; nothing clears while the ledger is not ready. Clearing removes the file and the in-memory entry, so no restart is needed.

Reconcile and probes. The participant registers only when TLibs has the estate API (Class.forName probe), settles every decided estate on the first tick and hourly, and reports with the revision answered, only when the outcome changes. On TLibs 2.5.0 the plugin still enables (checked by loading and verifying ShopMain against the 2.5.0 jar) and simply does not take part.

Pins TLibs 2.6.0, which is not released yet, so CI may fail resolving it until it is.

Docs: TF-Minecraft/Docs#214

Review. Muse's minor findings are addressed in b995f6f: journals from another death are refused, a reconcile failure on one estate no longer stops the others, plus the repository-specific items.

Tests. tfmc-mvn -o -B --no-transfer-progress clean verify: 256 tests, 0 failures (no coverage gate is configured). New tests cover the pause in both directions, the in-place owner rewrite, the transfer, idempotent re-settles, crash replay after the plan and after the shop write, removed or given-away shops, blocked shops then retry, waiting and frozen property, guard and readiness, the reconcile's change-only reporting, chained estates, registration, the probe, and every row of the intent table.

🤖 Generated with Claude Code

[coderabbitai]

Important

Draft PR not reviewed

Draft PRs are not automatically reviewed by default.

• Trigger a manual review

To automatically review draft PRs, update your CodeRabbit configuration:

reviews:
  auto_review:
    drafts: true

• Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

_{Comment @coderabbitai help to get the list of available commands.}