Skip to content

fix: preserve player-kept horses on chunk load - #55

Closed
XxFran10xX wants to merge 1 commit into
mainfrom
fix/horse-cleanup-protection
Closed

XxFran10xX wants to merge 1 commit into
mainfrom
fix/horse-cleanup-protection

Conversation

@XxFran10xX

Copy link
Copy Markdown
Contributor

Problem and fix

Cooking removed horses on chunk load when they had no Cooking owner or enrolled mount record, even if they were vanilla-tamed, named, or saddled. The live remove-unowned list includes horses.

Preserve tamed, named, or saddled AbstractHorse mounts and apply persistence flags even when no Cooking record exists. Existing enrollment, stats, ownership, and wild livestock cleanup remain in place. This prevents future removals; it does not restore previously lost entities.

Validation

  • Reviewed the diff and live cleanup configuration.
  • mvn -B --no-transfer-progress clean verify: 254 tests passed.
  • Eight new lifecycle regression tests; five fail against the original cleanup implementation.
  • Dev server validation pending before merge.

@coderabbitai

coderabbitai Bot commented Sep 29, 2026

Copy link
Copy Markdown

Review in Change Stack →

Navigate logical layers of code changes, visualize relationships, and explore their blast radius.

Note

Currently processing new changes in this PR. This may take a few minutes, please wait...

⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Advanced

Run ID: 417d4e1e-a8f9-4c62-8ff1-a704691263e2

📥 Commits

Reviewing files that changed from the base of the PR and between 6ee9e89 and 150873f.

📒 Files selected for processing (3)
  • src/main/java/net/tfminecraft/cooking/husbandry/HusbandryLifecycleListener.java
  • src/main/java/net/tfminecraft/cooking/husbandry/HusbandryMounts.java
  • src/test/java/net/tfminecraft/cooking/husbandry/HusbandryMountPersistenceTest.java
 _________________________________________________
< Artificial intelligence, natural bug detection. >
 -------------------------------------------------
  \
   \   (\__/)
       (•ㅅ•)
       /   づ
✨ Finishing Touches
📝 Generate docstrings
  • Commit to this branch
  • Create a new PR
🧪 Generate unit tests (beta)
  • Commit to this branch
  • Create a new PR

Comment @coderabbitai help to get the list of available commands.

@XxFran10xX XxFran10xX closed this Sep 29, 2026
@XxFran10xX
XxFran10xX deleted the fix/horse-cleanup-protection branch September 29, 2026 20:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant