fix: show the claim hint for ridden unowned mounts - #60
Conversation
Riding enrolls a horse before the hint check, so needsClaim was false and horse riders never saw how to claim or their animal limit. Hint every unowned remove-unowned animal; ridden mounts the cleanup keeps say that anyone can ride or claim them instead of that they vanish. Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com>
|
Navigate logical layers of code changes, visualize relationships, and explore their blast radius. No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Advanced Run ID: 📒 Files selected for processing (2)
Included review availability: This review used your included allowance. Your plan provides up to 10 included reviews per hour; 7 remain after this review. 📝 WalkthroughWalkthroughClaim hints now include unowned animals configured for unowned removal, including animals that remain wild. The warning text distinguishes wild animals from animals that disappear when their area loads. Tests cover both unowned and owned horses. ChangesHusbandry Claim Hints
Priority: ⬇️ Low Estimated code review effort: 2 (Simple) | ~10 minutes Change: Bug fix Merge Risk: ⚪ Minimal · up to This change shows claim hints to players who ride unowned mounts, and the wording now says whether the animal will disappear. No merge-blocking risk was found. 🚥 Pre-merge checks | ✅ 4 | ❌ 1❌ Failed checks (1 warning)
✅ Passed checks (4 passed)
✨ Finishing Touches 💡 1📝 Generate docstrings 💡
🧪 Generate unit tests (beta)
A rabbit reads the hint with care, Comment |
Summary
needsClaimis false for enrolled mounts, horse riders never got the claim hint or their animal count. The main case fix: keep only Cooking-owned horses and explain claiming #57 was meant to explain was silent.HusbandryClaimHint.sendnow fires for any unowned animal on theremove-unownedlist (isUnclaimed).needsClaimstill decides the wording:Documentation impact
Contract
mvn clean verifypassed 276 tests (0 failures). New tests: a ridden unowned horse gets the "anyone can ride it" hint with the tame step and count; an owned horse gets no hint.ProvinceSystem/wiki/animal-husbandry): no change.Notes
src/main/resources. Do not edittarget/.cookware.ymlis not loaded.🤖 Generated with Claude Code
Summary by CodeRabbit