Skip to content

fix: redraw packet cards on return and restart a stuck blackjack clock - #34

Closed
Drefvelin wants to merge 1 commit into
TF-Minecraft:mainfrom
Drefvelin:main
Closed

Drefvelin wants to merge 1 commit into
TF-Minecraft:mainfrom
Drefvelin:main

Conversation

@Drefvelin

Copy link
Copy Markdown
Contributor

Summary

  • Packet cards are spawned again when a player reloads their chunk or walks back into display range. A metadata update cannot recreate an entity the client already dropped.
  • An automatic blackjack table with a legal bet and no running countdown starts that countdown again. Claiming the shoe and then leaving used to cancel the clock and leave the chips sitting there, which is the stuck window on The Bog.
  • Leaving after bets close already forfeits the stake to the house tray, or to a private dealer. Leaving while the window is still open still refunds the bet. That rule is unchanged.

Test plan

  • mvn -B --no-transfer-progress -P'!deploy-live' test (1126 tests)
  • PR build stamps a DEV-YYYYMMDD-HHMM jar and passes
  • Walk out of a card chunk and back in; the cards are visible without waiting for another update
  • On an automatic blackjack table, bet, claim the shoe, then leave; the countdown starts again and the hand deals
  • Bet, wait until the window closes, then leave; the stake stays and is paid to the dealer

Made with Cursor

Clients drop fake card entities when a chunk unloads, and a metadata update never brings them back. An automatic table can also reopen with a legal bet and no countdown after a dealer claim or leave, so the window never closes.

Co-authored-by: Cursor <cursoragent@cursor.com>
@coderabbitai

coderabbitai Bot commented Oct 6, 2026

Copy link
Copy Markdown

Review in Change Stack →

Note

Currently processing new changes in this PR. This may take a few minutes, please wait...

⚙️ Run configuration
  • Configuration used: Organization UI
  • Review profile: CHILL
  • Plan: Advanced
  • Run ID: 9ac4296a-f3f8-448c-ab51-9789623bffde
📥 Commits

Reviewing files that changed from the base of the PR and between 1c7a7f1 and 55b5f8e.

📒 Files selected for processing (6)
  • src/main/java/net/tfminecraft/games/display/DisplayManager.java
  • src/main/java/net/tfminecraft/games/game/BlackjackGame.java
  • src/main/java/net/tfminecraft/games/game/Game.java
  • src/main/java/net/tfminecraft/games/table/TableManager.java
  • src/test/java/net/tfminecraft/games/display/DisplayManagerTest.java
  • src/test/java/net/tfminecraft/games/game/BlackjackGameTest.java
  • Autopilot · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

Comment @coderabbitai help to get the list of available commands.

@Drefvelin

Copy link
Copy Markdown
Contributor Author

Superseded by #35. This pull request came from a fork, so the build could not read the pinned-dependency token and failed in prepare-release. The same commit is on `fix/blackjack-forfeit-and-card-redraw` in this repository.

@Drefvelin Drefvelin closed this Oct 6, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant