Bind the Mitlan rune spells - #41
XxFran10xX wants to merge 1 commit into
Conversation
Mitlan gets eight rune spells, two per tier, mixing Oseni damage with Seithr defense. Bind them to Mitlan at their tiers in the bundled skills.yml, and give the element its rune icon and rune colour instead of the lapis placeholder. Live servers keep their own copies of both files. Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com>
|
Navigate logical layers of code changes, visualize relationships, and explore their blast radius. No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Advanced Run ID: 📒 Files selected for processing (2)
Included review availability: This review used your included allowance. Your plan provides up to 10 included reviews per hour; 7 remain after this review. 📝 SummarySummary by CodeRabbit
WalkthroughMitlan’s element now uses its rune glyph and a green-teal colour. Eight Mitlan skills are added to the skill configuration, with two skills assigned to each tier from 1 through 4. ChangesMitlan configuration
Priority: ⬇️ Low Estimated code review effort: 1 (Trivial) | ~4 minutes Change: Feature Suggested reviewers: Merge Risk: ⚪ Minimal · up to Mitlan’s appearance and eight spell-tier bindings are updated. The author reports server testing (E1), though the external spell and rune definitions could not be verified here; no concrete merge blocker is established, and normal server validation should confirm them. Architecture SummaryArchitecture risk: 🔵 Low · up to The change affects 1 system. Changed systems: Architecture concerns Review detailsSystems and components
Before / after behavior
Comment |
Mitlan gets eight rune spells, two per tier. Mitlan comes from mixing Oseni (damage) and Seithr (defense), so each spell does some damage and also pushes, pulls, slows, holds or shields.
This PR updates the bundled defaults only:
skills.ymlbinds the eight spells to Mitlan at their tiers.elements.ymlgives Mitlan its rune icon (m.mitlan_runes.rune_of_mitlan_glyph) and rune colour#3b8268, replacing the lapis placeholder.The spells themselves (MMOItems runes, MythicLib handlers, MythicMobs skills), the runestone pools and the Recycler recipes are server configs. They were tested on TFMCDev01 with bot casts, including Magic's refusals: "never attuned to Mitlan" on an Oseni weapon, and "needs Mitlan I/IV" without resonance.
mvn testforConfigurationTest,ArtifactConfigurationTest,ArtifactConfigEdgeTestandSacrificeConfigEdgeTestpasses; the bundled skills.yml now loads 28 bindings.🤖 Generated with Claude Code