Skip to content

Bind the Mitlan rune spells - #41

Open
XxFran10xX wants to merge 1 commit into
mainfrom
feat/mitlan-rune-spells
Open

XxFran10xX wants to merge 1 commit into
mainfrom
feat/mitlan-rune-spells

Conversation

@XxFran10xX

Copy link
Copy Markdown
Contributor

Mitlan gets eight rune spells, two per tier. Mitlan comes from mixing Oseni (damage) and Seithr (defense), so each spell does some damage and also pushes, pulls, slows, holds or shields.

Tier Damage leaning Defense leaning
Minor Tide Shard Bubble Shard
Lesser Scalding Wave Tidal Shield
Greater Crashing Wave Mitlan Glyph
Ascendant Maelstrom Drowning Prison

This PR updates the bundled defaults only:

  • skills.yml binds the eight spells to Mitlan at their tiers.
  • elements.yml gives Mitlan its rune icon (m.mitlan_runes.rune_of_mitlan_glyph) and rune colour #3b8268, replacing the lapis placeholder.

The spells themselves (MMOItems runes, MythicLib handlers, MythicMobs skills), the runestone pools and the Recycler recipes are server configs. They were tested on TFMCDev01 with bot casts, including Magic's refusals: "never attuned to Mitlan" on an Oseni weapon, and "needs Mitlan I/IV" without resonance.

mvn test for ConfigurationTest, ArtifactConfigurationTest, ArtifactConfigEdgeTest and SacrificeConfigEdgeTest passes; the bundled skills.yml now loads 28 bindings.

🤖 Generated with Claude Code

Mitlan gets eight rune spells, two per tier, mixing Oseni damage with
Seithr defense. Bind them to Mitlan at their tiers in the bundled
skills.yml, and give the element its rune icon and rune colour instead of
the lapis placeholder. Live servers keep their own copies of both files.

Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com>
@coderabbitai

coderabbitai Bot commented Oct 1, 2026 •

Copy link
Copy Markdown

Review in Change Stack →

Navigate logical layers of code changes, visualize relationships, and explore their blast radius.

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Advanced

Run ID: 6ed74c55-66d7-4fdf-adfe-7871abb9de05

📥 Commits

Reviewing files that changed from the base of the PR and between d089e13 and 3a2a7dc.

📒 Files selected for processing (2)
  • src/main/resources/elements/elements.yml
  • src/main/resources/skills.yml

Included review availability: This review used your included allowance. Your plan provides up to 10 included reviews per hour; 7 remain after this review.


📝 Summary

Summary by CodeRabbit

  • New Features
    • Added eight Mitlan skills across tiers 1–4, including Tide Shard, Scalding Wave, Mitlan Glyph and Maelstrom.
  • Visual Updates
    • Mitlan now displays a rune glyph and uses a green-teal colour instead of the previous lapis lazuli icon and blue colour.

Walkthrough

Mitlan’s element now uses its rune glyph and a green-teal colour. Eight Mitlan skills are added to the skill configuration, with two skills assigned to each tier from 1 through 4.

Changes

Mitlan configuration

Layer / File(s) Summary
Mitlan element and skill configuration
src/main/resources/elements/elements.yml, src/main/resources/skills.yml
Mitlan’s icon and colour change. Eight skills are assigned across tiers 1 through 4.

Priority: ⬇️ Low

Estimated code review effort: 1 (Trivial) | ~4 minutes

Change: Feature

Suggested reviewers: drefvelin

Merge Risk: ⚪ Minimal · up to 3a2a7

Mitlan’s appearance and eight spell-tier bindings are updated. The author reports server testing (E1), though the external spell and rune definitions could not be verified here; no concrete merge blocker is established, and normal server validation should confirm them.

Architecture Summary

Architecture risk: 🔵 Low · up to 3a2a7

The change affects 1 system.

Changed systems: src

Architecture concerns
No architecture-level concerns identified.

Review details

Systems and components

  • observed — src (service) was modified; 2 changed files map to changed impact.

Before / after behavior

  • observed — Modified behavior in src/main/resources/elements/elements.yml: Mitlan’s icon changes from v.LAPIS_LAZULI to its rune glyph, and its colour changes from #5555ff to #3b8268.
  • observed — Modified behavior in src/main/resources/skills.yml: Adds eight skill bindings for Mitlan, assigning two skills to each tier from 1 through 4.
  • Autopilot · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

Autopilot is currently an internal CodeRabbit preview.


Comment @coderabbitai help to get the list of available commands.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant