Skip to content

fix: reword player messages in character - #25

Merged
ryanbarlow97 merged 1 commit into
mainfrom
copy/rp-wording
Oct 1, 2026
Merged

ryanbarlow97 merged 1 commit into
mainfrom
copy/rp-wording

Conversation

@ryanbarlow97

Copy link
Copy Markdown
Contributor

Summary

Rewords player-facing gameplay messages that broke immersion with server terms (permissions, access, containers, entities, chunks, plugin names) so they read in character. Staff and admin commands, usage help and setup errors keep their plain wording. Wording only: no permission checks or message routing change.

Before and after

Colour codes are omitted; the code keeps them.

Before After
Could not find this trade. The market no longer buys this.

Testing

mvn -o verify passes: 31 tests, 0 failures.

🤖 Generated with Claude Code

Replace out-of-character wording in gameplay messages (permissions,
containers, entities, chunks, plugin tags) with in-world phrasing.
Staff commands, usage help and setup errors keep their plain wording.

Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com>
@coderabbitai

coderabbitai Bot commented Oct 1, 2026 •

Copy link
Copy Markdown

Review in Change Stack →

Navigate logical layers of code changes, visualize relationships, and explore their blast radius.

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Advanced

Run ID: 60f4fc05-db3d-46cf-b1a9-a895870f0203

📥 Commits

Reviewing files that changed from the base of the PR and between 904f9f5 and 0bc24d6.

📒 Files selected for processing (1)
  • src/main/java/net/tfminecraft/marketblock/manager/TradeManager.java

Included review availability: This review used your included allowance. Your plan provides up to 10 included reviews per hour; 7 remain after this review.


📝 Summary

Summary by CodeRabbit

  • Bug Fixes
    • Updated the message shown when a trade is no longer available to clarify that the market no longer buys the item.

Walkthrough

The message shown to a player changes when a trade ID no longer resolves to a trade.

Changes

Trade lookup message

Layer / File(s) Summary
Null lookup response
src/main/java/net/tfminecraft/marketblock/manager/TradeManager.java
When a trade lookup returns null, the message changes from “Could not find this trade.” to “The market no longer buys this.”

Priority: ⬇️ Low

Estimated code review effort: 1 (Trivial) | ~5 minutes

Change: Other

Suggested reviewers: drefvelin

Merge Risk: ⚪ Minimal · up to 0bc24

The revised message accurately describes clicks on offers that have been removed from the market. No actionable merge risk remains.

  • Autopilot · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

Autopilot is currently an internal CodeRabbit preview.


Comment @coderabbitai help to get the list of available commands.

@ryanbarlow97
ryanbarlow97 merged commit c52b705 into main Oct 1, 2026
2 checks passed
@ryanbarlow97
ryanbarlow97 deleted the copy/rp-wording branch October 1, 2026 11:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant