Repository navigation
Show characters as cards on Profile - #188
Merged
Merged
Conversation
The Characters tab listed characters as bare rows whose hover band ran flush to the text. They now sit in a two-column grid of bordered cards with an initial, a status chip and a chevron, matching the wardrobe cards. A dashed "New character" tile replaces the Create button, the slot count gains pips, and dead characters move to a quieter section. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
|
Warning Review limit reachedYou've used all free OSS reviews for now. Wait for the free limit to reset to keep reviewing this public repository. Next included review available in 20 minutes. View limit details
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
The letter crest said nothing. Each card now shows the face of the skin the character wears, read from its wardrobe, and falls back to the player's own head for characters with no skin of their own, pending and rejected characters, and blank faces such as the masked template. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Loading faces through GET /characters/{id}/wardrobe enforced slot limits,
which can delete locked extra skins and reset the active slot, so merely
opening Profile could change wardrobes. GET /characters/{id}/face picks
the worn slot the same way without writing anything and returns the 8x8
face, one request per character. Faces now reload with each dashboard
load or Refresh, and a new session never shows the previous one's faces.
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
This branch was successfully deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
GET /characters/{id}/face. It picks the worn slot like the wardrobe does (a locked or empty active slot falls back to base) but never enforces limits or saves anything, unlikeGET /characters/{id}/wardrobe. It returns an 8×8 PNG, or 404no_face. Characters with no skin of their own, pending and rejected characters, and blank faces (the masked template) show the player's own head instead.Testing
npx vitest run(2117 passed, including newCharacterList.test.tsx),oxlint,oxfmt --check,tsc --noEmit.test_wardrobe_face.py(crop, legacy skins, blank faces, locked active slot leaves the wardrobe untouched, ownership) andtest_character_face_route.py.🤖 Generated with Claude Code