Repository navigation
Keep the scrollbar's room on every page - #189
Merged
Merged
Conversation
The page scrollbar appeared once content grew past the screen (opening the skin editor on Profile, for one), which narrowed the viewport and slid the whole page sideways. Staff pages already reserved the gutter; every page now does, except the full-screen map, which never scrolls. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
|
Warning Review limit reachedYou've used all free OSS reviews for now. Wait for the free limit to reset to keep reviewing this public repository. Next included review available in 2 minutes. View limit details
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
This branch was successfully deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Opening the skin editor on Profile made the page long enough to scroll; the scrollbar appeared, the viewport narrowed and the whole page, header included, slid about 8px left. Closing it slid everything back.
Staff pages already reserved the scrollbar's gutter (
html:has(.staff-panel)). This makes that rule site-wide (html:not(.map-fullscreen)), so no page shifts as it grows or shrinks. The full-screen map never scrolls, so it keeps the whole width. Touch screens hide the page bar (#187), so they reserve nothing. Thestaff-panelclass only existed for the old rule and is removed.Preview: https://fix-stable-scrollbar-gutter.tfminecraft.net
🤖 Generated with Claude Code