Skip to content

Add Codex population placeholders - #79

Merged
Drefvelin merged 1 commit into
mainfrom
feat/codex-population-placeholders
Oct 8, 2026
Merged

Drefvelin merged 1 commit into
mainfrom
feat/codex-population-placeholders

Conversation

@Drefvelin

Copy link
Copy Markdown
Contributor

Summary

  • %rpcharacters_codex_percent_<category>:<discovery>% returns the nearest whole percent of Codex accounts that have that entry, and %rpcharacters_codex_holders_<category>:<discovery>% returns the count. An unknown category or entry is blank.
  • Counts come from Codex's saved player files, with online players overlaid from live Codex data. Placeholder lookups read a snapshot that refreshes about once a minute off the main thread.

Test plan

  • PR build (DEV-<timestamp>) goes green, including JaCoCo line coverage
  • After merge, confirm %rpcharacters_codex_percent_achievements:die% and %rpcharacters_codex_holders_achievements:die% resolve once the snapshot has refreshed
  • Confirm an unknown id stays blank and a defined id with no holders is 0

Made with Cursor

Placeholder lookups stay cheap because the holder counts refresh about once a minute instead of scanning Codex files on every request.

Co-authored-by: Cursor <cursoragent@cursor.com>
@coderabbitai

coderabbitai Bot commented Oct 8, 2026

Copy link
Copy Markdown

Review in Change Stack →

Note

Currently processing new changes in this PR. This may take a few minutes, please wait...

⚙️ Run configuration
  • Configuration used: Organization UI
  • Review profile: CHILL
  • Plan: Advanced
  • Run ID: 9f2cc991-8497-492a-b474-1827957c0666
📥 Commits

Reviewing files that changed from the base of the PR and between 628d185 and 85d9f93.

📒 Files selected for processing (11)
  • README.md
  • src/main/java/net/tfminecraft/rpcharacters/RPCharacters.java
  • src/main/java/net/tfminecraft/rpcharacters/placeholder/CodexLiveReader.java
  • src/main/java/net/tfminecraft/rpcharacters/placeholder/CodexPopulation.java
  • src/main/java/net/tfminecraft/rpcharacters/placeholder/CodexPopulationService.java
  • src/main/java/net/tfminecraft/rpcharacters/placeholder/RpCharactersExpansion.java
  • src/main/resources/plugin.yml
  • src/test/java/net/tfminecraft/rpcharacters/placeholder/CodexLiveReaderTest.java
  • src/test/java/net/tfminecraft/rpcharacters/placeholder/CodexPopulationServiceTest.java
  • src/test/java/net/tfminecraft/rpcharacters/placeholder/CodexPopulationTest.java
  • src/test/java/net/tfminecraft/rpcharacters/placeholder/RpCharactersExpansionTest.java
  • Autopilot · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@Drefvelin
Drefvelin merged commit 2b619c3 into main Oct 8, 2026
1 of 2 checks passed
@Drefvelin
Drefvelin deleted the feat/codex-population-placeholders branch October 8, 2026 09:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant