Add guild branches that improve supply hubs - #92
Merged
Merged
Conversation
Supply Lines gives a guild one more hub every two levels and makes its hubs pass on 3% more trade power per level. Freight Yards makes them pass on 8% more production per level. Both are open to guilds and realms. Shares stay capped at 95%. A guild with more hubs than its limit keeps them, but the newest ones beyond the limit are dormant. The branch upgrade preview shows what a level would add before it is bought. Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com>
|
Navigate logical layers of code changes, visualize relationships, and explore their blast radius. No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Advanced Run ID: 📒 Files selected for processing (12)
Included review availability: This review used your included allowance. Your plan provides up to 10 included reviews per hour; 6 remain after this review. 📝 SummarySummary by CodeRabbit
WalkthroughThe change adds guild modifiers for supply hub limits, trade transfer and production transfer. It applies guild-specific limits to hub availability and uses boosted link factors in trade and production delivery. ChangesGuild supply hub modifiers
Priority: ⬇️ Low Estimated code review effort: 3 (Moderate) | ~20 minutes Change: Feature Sequence Diagram(s)sequenceDiagram
participant ProvinceManager
participant GuildModifierOverride
participant HubTransportLink
ProvinceManager->>GuildModifierOverride: Resolve HUB_TRADE bonus
ProvinceManager->>HubTransportLink: Calculate boostedTradeFactor(bonus)
HubTransportLink-->>ProvinceManager: Return distance-adjusted factor
ProvinceManager->>ProvinceManager: Apply factor to hub trade delivery
Merge Risk: ⚪ Minimal · up to The change adds two guild branches that raise hub limits and transfer shares. No concrete merge-blocking issue was found in the supplied changes. Security Architecture ReviewSecurity architecture risk: 🔵 Low · up to The changes affect which supply hubs operate and how much they transfer. Existing membership, leadership, and owner-permission checks remain in place, and transfer bonuses remain capped. No introduced security bypass was established, but hypothetical limit previews and complete recovery behavior remain incompletely verified. Retained concerns Security review detailsSecurity Blast Radius
Trust Boundaries and Controls
Resilience and Maintainability Implications
Comment |
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Two new guild branches for supply hubs, open to guilds and realms.
Both also add a little trade upkeep and prestige, like the existing branches.
How it works
HUB_LIMIT,HUB_TRADE,HUB_PRODUCTION.supply-hubs.base-limitplus the whole part ofHUB_LIMIT.GuildModifierOverride, so the branch upgrade income preview shows a level's effect without rebuilding the hub network. Cached links stay unboosted./guild hub listshows hubs used / limit and the boosted shares.Testing
mvn verify: 2464 tests, 0 failures. New tests cover the modifier maths and cap, the limit, over-limit dormancy, the recalculation with a boosted share, the branch preview and branch loading for both guild types.🤖 Generated with Claude Code