Skip to content

build: order pom.xml properties per TFMC conventions - #25

Merged
ryanbarlow97 merged 1 commit into
mainfrom
chore/repo-norms
Oct 3, 2026
Merged

ryanbarlow97 merged 1 commit into
mainfrom
chore/repo-norms

Conversation

@ryanbarlow97

Copy link
Copy Markdown
Contributor

Summary

Part of a cross-repository audit against the TF-Minecraft repository norms (README layout per Docs MAINTAINING.md and the other plugin READMEs, POM layout per Docs POM-CONVENTIONS.md).

Checks

  • README text otherwise unchanged (sections moved verbatim).
  • Effective POM (maven-help-plugin:3.5.2:effective-pom, offline) compared before and after: identical apart from property order.

🤖 Generated with Claude Code

Put maven.compiler.release and project.build.sourceEncoding first, then
maven.compiler.proc, then the remaining properties alphabetically. The
effective POM is unchanged apart from property order.

Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com>
@coderabbitai

coderabbitai Bot commented Oct 3, 2026 •

Copy link
Copy Markdown

Review in Change Stack →

Navigate logical layers of code changes, visualize relationships, and explore their blast radius.

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration
  • Configuration used: Organization UI
  • Review profile: CHILL
  • Plan: Advanced
  • Run ID: 6b0c1e78-c3f4-4f66-bc0b-bd34b40580a0
📥 Commits

Reviewing files that changed from the base of the PR and between 32714b7 and 7716690.

📒 Files selected for processing (1)
  • pom.xml

Limit details: You’ve used all 10 included reviews currently available.


📝 Summary

Summary by CodeRabbit

  • Chores
    • Reordered build configuration properties; their values and behaviour are unchanged.

Walkthrough

The pom.xml property order changes. The values of argLine, maven.compiler.release and project.build.sourceEncoding remain unchanged.

Changes

Maven properties

Layer / File(s) Summary
Reorder Maven properties
pom.xml
The compiler release and source encoding properties move after argLine. All three property values remain unchanged.

Priority: ⬇️ Low

Estimated code review effort: 1 (Trivial) | ~2 minutes

Change: Other

Suggested reviewers: justinasla

Merge Risk: ⚪ Minimal · up to 77166

No build behavior change is identified in the property reorder, so no merge-blocking issue remains.

Architecture Summary

Architecture risk: 🔵 Low · up to 77166

The change affects 1 system.

Changed systems: pom.xml

Architecture concerns
No architecture-level concerns identified.

Review details

Systems and components

  • observed — pom.xml (service) was modified; 1 changed file maps to changed impact.

Before / after behavior

  • observed — Modified behavior in pom.xml: The compiler release and source encoding properties move after <argLine>; all three property values are unchanged.
  • Autopilot · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

Usage-based review receipt

  • Mode: Continue automatically
  • Reviewed files: 1
  • Waived: $0.25 (charged $0.00)
  • View usage details

Note

This review exceeded your plan’s limits and used usage-based reviews—free during trial, billed after paid activation unless disabled. Manage usage-based reviews.


Comment @coderabbitai help to get the list of available commands.

@ryanbarlow97
ryanbarlow97 merged commit 2c59799 into main Oct 3, 2026
2 checks passed
@ryanbarlow97
ryanbarlow97 deleted the chore/repo-norms branch October 3, 2026 22:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant