fix(showcase): wall-torch and signpost visual quality pass - #184
Merged
Merged
Conversation
Future pieces inherit axis-aligned boards (exit 19) and wall-sconce plaque bottoms at Z=0 (exit 16), plus finger tips cut from the member section rather than glued cubes. Signed-off-by: TMHSDigital <154358121+TMHSDigital@users.noreply.github.com> Co-authored-by: Cursor <cursoragent@cursor.com>
Rebuild the sconce from named plate and cup stations so it reads as a wall torch: running-bond ashlar, a round arm into an upward bowl, plaque zmin at 0. Hygiene 15-19 and joint-fit budgets lock the contacts. Signed-off-by: TMHSDigital <154358121+TMHSDigital@users.noreply.github.com> Co-authored-by: Cursor <cursoragent@cursor.com>
Axis-align the boards, cut finger tips from the board section, and wrap the shoe as a closed collar so it reads as a fingerpost. Hygiene 15-19 plus orthogonal-board and named-shoe budgets lock the joints. Signed-off-by: TMHSDigital <154358121+TMHSDigital@users.noreply.github.com> Co-authored-by: Cursor <cursoragent@cursor.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Visual quality pass on wall-torch and signpost — the two remaining pieces that had not had one. Both were budget-correct and looked like toys. Generators rebuilt from named stations; hygiene 15–19 locked in. Inspection sheets stayed in
.scratch/(never committed).showcase/README.mdgains Orthogonal members (exit 19) and Wall-mount zmin (exit 16) so future pieces inherit them.wall-torch
Round-1 defects (view that revealed each):
v.co.z += 0.14(ground.png; README zmin 0.140).Fixes (structural):
CUP_Y - CUP_R1 + ARM_BITE.cap_trisfor segs > 4); haft seated in the bowl; short flame cones in the rim.Hygiene measured on 4.5.11 / 5.1.2 / 5.2.1: all zero; zmin 0; arm-cup gap 0.00087; plate-plaque 0.004; plaque width 0.280.
--skip-decimate--stray-vert--lift-z--float-arm--float-plate--skinny-plaqueWALL_WTris 848 → 1528 (coursing). Inspection rounds: 3. Hero re-rendered on 5.2.1 Cycles;
check_framingwith nodeviation=(fill_y=0.817).signpost
Round-1 defects:
Fixes (structural):
yaw = 0;--yaw-boardsis the 19 falsifier.BOARD_T × BOARD_H, bitten into the board (TIP_BITE).(half + CAP_OVERHANG) * sqrt(2).omit_x_sign).Hygiene on all three binaries: all zero; shoe_z 0; board-gap 0.005; strap-gap 0.003; board AABB Y 0.028.
--skip-decimate--stray-vert--lift-z/--short-shoe--gap-board--float-strap--yaw-boardsTris 504 → 376. Inspection rounds: 3. Hero on 5.2.1 Cycles; framing passed.
Proven vs inspection-only
Live run: defaults and every falsifier on 4.5.11, 5.1.2, 5.2.1; Cycles heroes; framing fill/margins on 5.2.1.
Inspection only: visual defect lists from
.scratch/inspect/r1–r3PNGs (untracked).Test plan
needs-5.15.1 smoke appears and is green