fix: sign off release bumps and drop the dead Pages path filter - #198
Merged
Merged
Conversation
CONTRIBUTING.md § DCO sign-off requires a Signed-off-by trailer matching the commit author, and the inbound grant it describes is what resolves this project's CC-BY-NC-ND outbound/inbound conflict. Every release bump commit on main since automation landed carries no trailer. Add -s to the "Commit version bump" step. git config user.name and user.email are already set to github-actions[bot] two lines above, so the trailer matches the author with no further change: Signed-off-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com> Only the bump commit's -s flag changes; the rest of release.yml is untouched. Existing history is not rewritten — main is force-push protected. Closes #193 Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com> Signed-off-by: TMHSDigital <154358121+TMHSDigital@users.noreply.github.com>
pages.yml path-filtered its push trigger on mcp-tools.json, a file that has never existed in this repository: $ git log --oneline --all -- mcp-tools.json (no output) It is fleet scaffolding, not removed-feature residue. The vendored landing builder (scripts/site/build_site.py:274) reads it optionally and returns [] when absent, because the builder serves tool repos generally and some of those do ship an MCP server. This one does not. The filter was inert — a path that cannot change never matches, so it neither triggered nor suppressed a deploy. Removing it costs nothing and stops a reader auditing pages.yml concluding an MCP server was half-removed. Nothing else in pages.yml changes; every other path stays exactly as it was. Closes #195 Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com> Signed-off-by: TMHSDigital <154358121+TMHSDigital@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Two one-line workflow fixes, one commit each. These are the only sanctioned changes to
release.ymlandpages.yml; nothing else in either file moves.#193 — DCO on release bumps (
b66b197)CONTRIBUTING.md§ DCO sign-off requires aSigned-off-by:trailer matching the commit author, and the inbound grant it describes is what resolves the CC-BY-NC-ND outbound/inbound conflict. Every bump commit onmaincarries none:The "Commit version bump" step now runs
git commit -s.git config user.name/user.emailare already set togithub-actions[bot]two lines above, so the trailer matches the author with no further change:Release-path risk. This touches the step that pushes to protected
main. That push has survived two live releases under themain-integrityruleset (c6a7951→v0.78.19,bd5d15b→v0.78.20), and-sonly appends a trailer — it changes neither the ref, the push, nor the commit's parentage, so the ruleset evaluates it identically. This PR isfix:-prefixed and will cut a release, so the next bump is the live test: verify it lands, tags, cuts the GitHub release, dispatches Pages, and carries the trailer.#195 —
mcp-tools.jsonin the Pages filter (d6b8bb3)The path has never existed here:
Fleet scaffolding, not residue —
scripts/site/build_site.py:274reads it optionally and returns[]when absent, because the vendored builder serves tool repos generally and some do ship an MCP server. The filter was inert: a path that cannot change never matches, so it neither triggered nor suppressed a deploy. Removing it costs nothing and stops a reader concluding an MCP server was half-removed.Every other path in the filter is byte-identical. Diff is a single deleted line.
Pages verification. This PR touches only
.github/workflows/, which is not in the Pages path filter, so merging it will not deploy Pages by push — expected, and consistent with the documented behaviour inCONTRIBUTING.md. It will deploy via the post-tagworkflow_dispatchthatrelease.ymlfires. A true content-merge deploy is proven by the next showcase PR, which touchesshowcase/,examples/, anddocs/gallery/.Evidence status
Both changes are inspection-only in this PR — neither workflow runs its changed step on a pull_request event. Both become live-run-proven on merge, and that verification is reported back on the follow-up PR.
Closes #193
Closes #195
🤖 Generated with Claude Code